This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 35431 - CVS->Diff doesn't work
Summary: CVS->Diff doesn't work
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: CVS (show other bugs)
Version: 3.x
Hardware: PC All
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-14 13:43 UTC by dmladek
Modified: 2007-01-04 17:14 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dmladek 2003-08-14 13:43:11 UTC
Product Version       = NetBeans IDE Dev (Build
200308140100)
  Operating System      = Linux version
2.4.20-18.9 running on i386
  Java; VM; Vendor      = 1.4.2; Java HotSpot(TM)
Client VM 1.4.2-b28; Sun Microsystems Inc.
  Java Home             =
/usr/local/java/j2sdk1.4.2/jre
  System Locale; Encod. = cs_CZ; ISO-8859-2
  Home Dir; Current Dir = /usr/local/home/delphym;
/usr/local/forte/forte3/NBdev-last/netbeans/bin
============================================================

This is a regresion. Not sure when the
functionality broke,but it had to be between
30-Jul till now.

Reproduction:
=============

Have a [LMod] file
perform CVS->Diff on it
instead of showing differencies... diff try to lie
to you with the message:
"Diff showed no difference on the following file:
/bla/bla/k.java
OK"


From RunTime TAB  on the Standard Error TAB's from
command output is possible see following strange log:

Checking out pac1/A1.java
RCS:  /usr/local/CVSrepo/pac1/A1.java,v
VERS: 1.10
***************
Protocol error: Root request missing
 
Protocol error: Root request missing
Comment 1 Martin Entlicher 2003-08-18 14:21:30 UTC
This is most probably a regression caused by the fix of issue #34665,
I'll look at it.
Comment 2 Martin Entlicher 2003-08-18 16:45:06 UTC
Well, "java -jar cvslib.jar diff" works.
The problem seems to be in the invocation of library commands from the
diff action.
The manipulation with RootRequest probably changed the behavior of
some API calls.
Comment 3 Martin Entlicher 2003-08-18 17:49:27 UTC
The javacvs filesystem resets the connection for every command. Due to
the change in Client, the newly set connection was not initialized and
therefore the RootRequest (besides others) was missing.

This is fixed in Client in the main trunk. Every connection is
initialized:

Checking in Client.java;
/cvs/javacvs/libsrc/org/netbeans/lib/cvsclient/Client.java,v  <-- 
Client.java
new revision: 1.64; previous revision: 1.63
Comment 4 dmladek 2003-08-19 08:04:45 UTC
I'm glad I can VERIFY your fix in NBdev-40 #200308190100