This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 35372 - Little potential memleak in ShortcutAndMenuKeyEventProcessor
Summary: Little potential memleak in ShortcutAndMenuKeyEventProcessor
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: All All
: P4 blocker (vote)
Assignee: Tomas Zezula
URL:
Keywords: PERFORMANCE, SIMPLEFIX
Depends on:
Blocks:
 
Reported: 2003-08-12 09:48 UTC by Petr Nejedly
Modified: 2008-12-23 09:44 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Patch to fix this problem (976 bytes, patch)
2003-10-15 18:00 UTC, Tomas Zezula 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Nejedly 2003-08-12 09:48:31 UTC 
ShortcutAndMenuKeyEventProcessor holds reference
to the last event, while the event holds reference
to the event source. That means the last component
that received key event can't be freed from memory
(but only until another one gets the key event
routed through SAMKEP).
Although not a real leak, it is annoying while
looking for real leaks. Fix should be simple.
Comment 1 Petr Nejedly 2003-10-15 16:32:02 UTC 
Tomas said he will fix it.
Comment 2 Tomas Zezula 2003-10-15 18:00:05 UTC 
Created attachment 11876 [details]
Patch to fix this problem
Comment 3 Tomas Zezula 2003-10-15 18:03:10 UTC 
Petr, could you be so kind and try to run the core/windows/ test with
this patch. The tests does not work with Project build.
The patch should be quite safe, but for sure.
Thanks
Comment 4 Petr Nejedly 2003-10-16 10:56:25 UTC 
Did you wanted to see something like:
[printSummary]  Expected Passes: 18  Unexpected Passes: 0
[printSummary]  Expected Fails: 0  Unexpected Fails: 0  Errors: 0
[printSummary]  Total: 18  Success Rate: 100,00%
?

So here it goes :-)
Comment 5 Tomas Zezula 2003-10-16 12:45:38 UTC 
Thanks.
Ok, in that case I am going to commit the change.
Comment 6 Tomas Zezula 2003-10-16 12:47:59 UTC 
Fixed
Comment 7 Petr Nejedly 2003-10-21 10:50:03 UTC 
Can't leak anymore