This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 35231 - Commit Validation does not check whether global shortcuts work
Summary: Commit Validation does not check whether global shortcuts work
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: xtest (show other bugs)
Version: 3.x
Hardware: PC Linux
: P4 blocker (vote)
Assignee: Jiri Skrivanek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-01 15:17 UTC by Jaroslav Tulach
Modified: 2003-12-11 14:17 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2003-08-01 15:17:51 UTC 
I've modified some code in TopComponent and due to
that second and next invocation of global shortcut
(at least after opening an editor) were not
realized. In spite of that commit-validation
succeeded fine. 

I wonder whether the ide tests invoke some global
shortcuts using keyboard and if not I suggest that
to be fixed as it might help discover similar
problems like I ran into.

PS: Using unit tests might not help much as this
is more about KeyEvent processing and I do not
know where I should put such tests...
Comment 1 Jiri Skrivanek 2003-08-14 09:42:04 UTC 
I can add anything to IDE commit validation suite but remember that it
must not be extremly time consuming because developers would complain
about its duration.
In addition I am not sure if we can test all special cases. IMO, test
the second invocation is such a special case and it should be tested
in openide/core test suites.
If you still think that something should be added in the commit
validation suite, please write down which shortcuts should be tested.
Comment 2 Jaroslav Tulach 2003-08-14 16:49:01 UTC 
Which? Does not matter much. I just had a feeling that no global
action is invoked by a shortcut. If that is true, it should be
improved I think. If I am wrong, then close this as invalid.
Comment 3 Jiri Skrivanek 2003-08-18 12:43:32 UTC 
So, if it doesn't matter, I suggest to add the following into
IDECommitValidation.testMainMenu (even it is invoked by shortcut):

- open new wizard (Ctrl+N)
- close it
- open Javadoc Index Search (Shift+F1)
- close it
- open new breakpoint dialog( Ctrl+Shift+F8)
- close it

Is it enough?
Comment 4 Jaroslav Tulach 2003-08-20 08:01:34 UTC 
Enough. Btw. interesting trick would be to delete a breakpoint in
breakpoint list. There is a bug in 3.5 that this action requires
confirmation. I know we should catch it in unit tests, but...
Comment 5 Jiri Skrivanek 2003-08-25 10:12:53 UTC 
I am a little bit confused. To delete breakpoint from list in runtime
tab you need to select breakpoint, push Delete key and confirm
deletion. There is no shortcut which delete breakpoint or all
breakpoints at once.
Comment 6 Jiri Skrivanek 2003-08-27 10:21:22 UTC 
Suggested shortcuts test integrated in version 1.10.