This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 34102 - ValidateLayerConsistencyTest.testInstantiateAllInstances fails w/ moduleconfig=stable-with-apisupport
Summary: ValidateLayerConsistencyTest.testInstantiateAllInstances fails w/ moduleconfi...
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 3.x
Hardware: All All
: P4 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: TEST
Depends on:
Blocks:
 
Reported: 2003-06-02 20:17 UTC by Jesse Glick
Modified: 2008-12-22 17:17 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Suggested patch (1.04 KB, patch)
2003-06-03 17:45 UTC, Jaroslav Tulach
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2003-06-02 20:17:27 UTC
[Originally reported as issue #34022, tracking
XTest's failure to handle this failure message
correctly. But the failure is also incorrect so
tracking it separately.]

Reports:

Some instances cannot be created [
    File
Templates/API_Support/API_test_script.java thrown
exception java.lang.ClassNotFoundException:
Templates.API_Support.API_test_script, 
    File
Templates/API_Support/Editor_API/EditorSupport.java
thrown exception java.lang.ClassNotFoundException:
Templates.API_Support.Editor_API.EditorSupport, 
    File
Templates/API_Support/Modules_API/Installer.java
thrown exception java.lang.ClassNotFoundException:
Templates.API_Support.Modules_API.Installer, 
    File
Templates/API_Support/Services_API/XMLProcessor.java
thrown exception java.lang.ClassNotFoundException:
Templates.API_Support.Services_API.XMLProcessor]

Of course these instances cannot be created - no
one is supposed to try. (Actually I am not sure
why the many other *.java files in apisupport's
templates *didn't* fail.) In skipFile I see:

if (s.startsWith ("Templates/GUIForms")) return true;

etc., just skipping every .java file in Templates.
Why not just skip all of Templates to begin with?
Or if you want to check e.g.
Templates/Services/**/*.settings, at least
condense these checks to

if (s.endsWith(".shadow")) return true;
if (s.endsWith(".java")) return true;

Note also that I think for 4.0 we should stop
using InstanceCookie on "user" data objects like
*.java, and deprecate IC.Of. See thread "Customize
Bean action - do we need it?" on nbui, and also
issue #32749 and issue #31960. If we restricted
this cookie to actual settings, the layer
validation test would be simplified.
Comment 1 Jaroslav Tulach 2003-06-03 17:45:13 UTC
Created attachment 10575 [details]
Suggested patch
Comment 2 Jaroslav Tulach 2003-06-03 17:46:09 UTC
I suggest this patch, Jesse when you will do next build, can you
verify and apply it please?
Comment 3 Jesse Glick 2003-06-03 20:24:50 UTC
OK, will try it when I do the next build. Thanks.
Comment 4 Jesse Glick 2003-06-05 20:34:27 UTC
committed     Up-To-Date  1.3        
core/test/unit/src/org/netbeans/core/projects/ValidateLayerConsistencyTest.java
Comment 5 Marian Mirilovic 2005-07-13 13:25:12 UTC
closed