This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 34060 - "Source Comments" refresh does not remove obsoleted gutter annotations
Summary: "Source Comments" refresh does not remove obsoleted gutter annotations
Status: VERIFIED WORKSFORME
Alias: None
Product: contrib
Classification: Unclassified
Component: Tasklist (show other bugs)
Version: 3.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: tasklist-issues@contrib
URL:
Keywords: UI
Depends on:
Blocks:
 
Reported: 2003-05-30 18:22 UTC by Jesse Glick
Modified: 2003-12-17 17:23 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2003-05-30 18:22:15 UTC
org.netbeans.modules.tasklist.suggestions/1 [1.7
200305050100]
org.netbeans.modules.tasklist.docscan/1 [1.6
200304230100]
org.netbeans.modules.tasklist.core/1 [1.8
200305150100]
dev 030529

I had a source file open with 7 XXX comments in
it. They appeared in Sugg view under Source
Comments. I double-clicked one of them to jump to
it, and the light bulb gutter annotation appeared
with the tool tip being the comment - fine.

Then I delete the line with the comment, and start
implementing the to-do item. After a refresh, the
entry in Sugg view disappears correctly. But the
annotation in the Editor remained (now over the
line which had followed the comment). There does
not seem to be any way to make it go away except
by double-clicking some other XXX comment.

If a suggestion is removed from the list, any
outstanding annotations associated with it should
be removed. Probably this should happen also if
the Sugg view is closed. Compare compiler error
annotations for example - they are removed
automatically if (1) you edit the line, (2) you
recompile, (3) maybe if you close the compile
window too, not sure. If in doubt, make the
lifespan of an annotation shorter rather than longer.

BTW is it intentional that the light bulb
annotation only appears one at a time, and only
when you double-click a suggestion? By comparison
by error annotations I would have expected that
whenever the Sugg view is open, *every* line with
a suggestion would have the annotation. Was this
style explicitly rejected as producing too much
noise? I believe Eclipse and other IDEs routinely
show marginal color bars or such things for
possible problems and suggested changes.
Comment 1 Torbjorn Norbye 2003-07-17 06:34:04 UTC
Fixed. For simplicity, I remove the current-task marker as soon as the
document is edited; not only when the line being marked is edited.

> BTW is it intentional that the light bulb
> annotation only appears one at a time, and only

I tried having annotations added immediately, but it looked really
ugly. For example, for javac errors, the editor adds an annotation for
every line with a problem, and then the suggestions view adds its own.
So on every line you get multiple annotations, with the resulting
editor annotation-cycle button plus the second annotation alpha
blended under the source. Also, when you double click on a task to
have it fixed, I can't use focus/caret to show which of the multiple
suggestions on the screen you're about to fix, since the fix
confirmation dialog has input focus, not the editor. So I would need
to have a different marker anyway. One possibility is using
annotations without highlights for all suggestions in the editor, and
then for the "current" suggestion, use the same annotation but with a
background highlight (as is done today). Feel free to file a separate
enhancement request for showing annotations for all suggestions. (Btw,
in the usertask module I now do provide annotations immediately for
all user tasks with a corresponding editor position.)
Comment 2 Jesse Glick 2003-07-21 15:18:40 UTC
Don't think this is fully fixed - I think the main symptoms are gone.
I had a source file open and was correcting some Javadoc errors. I
would jump to each with F12 and correct it. BTW, old suggestions would
not disappear from the list as soon as I edited the document, but only
after I waited a moment and then made some *other* (unrelated) edit,
i.e. the list lagged behind reality by one reparse cycle - maybe that
is some unrelated bug. Anyway, after fixing everything it had
complained about, all the items disappeared from the Suggestions view
- but, the light bulb annotation remained on the line that had held
the last annotation. Maybe this problem is specific to the last
annotation in a file.

dev 030716
org.netbeans.api.tasklist/1 [1.1 200304230100]
org.netbeans.modules.tasklist.core/1 [1.12 030713]
org.netbeans.modules.tasklist.html/1 [1.3 ${buildnumber}]
org.netbeans.modules.tasklist.javaparser/1 [1.1 200304230100]
org.netbeans.modules.tasklist.javadoc/1 [1.2 ${buildnumber}]
org.netbeans.modules.tasklist.suggestions/1 [1.11 030713]
org.netbeans.modules.tasklist.docscan/1 [1.6 200304230100]
Comment 3 _ pkuzel 2003-11-06 09:19:45 UTC
I cannot reproduce.

I type F12, then after typing first char the annotation disappears.
Comment 4 Jesse Glick 2003-11-06 09:35:10 UTC
Yeah, seems to be working for me now too.

org.netbeans.api.tasklist/1 [1.2 200307230100]
org.netbeans.modules.tasklist.core/1 [1.12 030713]
org.netbeans.modules.tasklist.html/1 [1.3 ${buildnumber}]
org.netbeans.modules.tasklist.docscan/1 [1.7 200307230100]
org.netbeans.modules.tasklist.suggestions/1 [1.14 200307230100]
org.netbeans.modules.tasklist.pmd/1 [1.3 manual-09sep03]
org.netbeans.modules.tasklist.javaparser/1 [1.1 200304230100]