This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 33745 - PVCS: Lock commands not working if IDE is run from r/o directory.
Summary: PVCS: Lock commands not working if IDE is run from r/o directory.
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: -S1S-
Hardware: Sun Solaris
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-19 17:16 UTC by Jiri Kovalsky
Modified: 2003-05-23 14:27 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
The binary patch. To apply, unzip this file in <User-dir>/system/vcs/ folder and re-mount the PVCS filesystems. (21.27 KB, application/octet-stream)
2003-05-20 08:57 UTC, Martin Entlicher
Details
The contextual diff of the fix. (6.85 KB, patch)
2003-05-20 08:59 UTC, Martin Entlicher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Kovalsky 2003-05-19 17:16:38 UTC
Sun ONE Studio 5.0, RC build #030516
Solaris 5.8 with JDK 1.4.1 build #02

Description:
============
All PVCS un/locking commands always fail if IDE is
run in multiuser mode from read-only directory.
This is not working feature and must be fixed to
FCS.

Steps to reproduce:
===================
1. Install IDE as root and launch it as ordinary
user from default r/o instalation directory.
2. Mount PVCS filesystem and right click some
file.
3. Choose "PVCS|Lock" command from popup menu.
4. The command will fail.
Comment 1 Martin Entlicher 2003-05-19 17:49:19 UTC
The problem is, that 'vcs' command is trying to create a temporary
file in the current working directory of the process. The current
working directory of the process is identical to the current working
directory of the IDE. When the IDE is installed as a root, the user
process does not have write permission to the IDE's current working
directory (which is typically <Install-DIR>/bin) and therefore the
command fails, because it can not create a temporary file.
Comment 2 Martin Entlicher 2003-05-19 17:54:38 UTC
The problem is fixed in the main trunk for all operating systems (we
do a 'cd' to WORKDIR, which should always have write permission):

Checking in pvcsUnix.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsUnix.xml,v 
<--  pvcsUnix.xml
new revision: 1.37; previous revision: 1.36
done
Checking in pvcsUnixLoc_XX.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsUnixLoc_XX.xml,v 
<--  pvcsUnixLoc_XX.xml
new revision: 1.38; previous revision: 1.37
done
Checking in pvcsWin.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsWin.xml,v 
<--  pvcsWin.xml
new revision: 1.44; previous revision: 1.43
done
Checking in pvcsWin98.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsWin98.xml,v 
<--  pvcsWin98.xml
new revision: 1.41; previous revision: 1.40
done
Checking in pvcsWin98Loc_XX.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsWin98Loc_XX.xml,v 
<--  pvcsWin98Loc_XX.xml
new revision: 1.41; previous revision: 1.40
done
Checking in pvcsWinLoc_XX.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsWinLoc_XX.xml,v 
<--  pvcsWinLoc_XX.xml
new revision: 1.44; previous revision: 1.43
done
Comment 3 Martin Entlicher 2003-05-20 08:57:01 UTC
Created attachment 10339 [details]
The binary patch. To apply, unzip this file in <User-dir>/system/vcs/ folder and re-mount the PVCS filesystems.
Comment 4 Martin Entlicher 2003-05-20 08:59:24 UTC
Created attachment 10340 [details]
The contextual diff of the fix.
Comment 5 Martin Entlicher 2003-05-20 09:16:21 UTC
The fix is merged into the prj40_prototype branch:

Checking in pvcsUnix.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsUnix.xml,v 
<--  pvcsUnix.xml
new revision: 1.36.6.1; previous revision: 1.36
done
Checking in pvcsUnixLoc_XX.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsUnixLoc_XX.xml,v 
<--  pvcsUnixLoc_XX.xml
new revision: 1.37.6.1; previous revision: 1.37
done
Checking in pvcsWin.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsWin.xml,v 
<--  pvcsWin.xml
new revision: 1.43.6.1; previous revision: 1.43
done
Checking in pvcsWin98.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsWin98.xml,v 
<--  pvcsWin98.xml
new revision: 1.40.6.1; previous revision: 1.40
done
Checking in pvcsWin98Loc_XX.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsWin98Loc_XX.xml,v 
<--  pvcsWin98Loc_XX.xml
new revision: 1.40.6.1; previous revision: 1.40
done
Checking in pvcsWinLoc_XX.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsWinLoc_XX.xml,v 
<--  pvcsWinLoc_XX.xml
new revision: 1.43.6.1; previous revision: 1.43
done
Comment 6 Jiri Kovalsky 2003-05-20 10:27:48 UTC
Excellent. The patch helps, commands are working fine. No other
undesired side effect. Verified with Sun ONE Studio 5.0 #030516 and
pvcs33745.zip on Solaris 5.8.
Comment 7 Richard Gregor 2003-05-20 10:29:56 UTC
Code reviewed, without objections. 
Comment 8 _ ttran 2003-05-20 16:36:04 UTC
approved for 3.5
Comment 9 Martin Entlicher 2003-05-20 16:58:19 UTC
Thanks for the verification, review and approval.
The fix is merged into release35 branch:

Checking in pvcsUnix.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsUnix.xml,v 
<--  pvcsUnix.xml
new revision: 1.35.4.2; previous revision: 1.35.4.1
done
Checking in pvcsUnixLoc_XX.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsUnixLoc_XX.xml,v 
<--  pvcsUnixLoc_XX.xml
new revision: 1.35.4.3; previous revision: 1.35.4.2
done
Checking in pvcsWin.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsWin.xml,v 
<--  pvcsWin.xml
new revision: 1.42.4.2; previous revision: 1.42.4.1
done
Checking in pvcsWin98.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsWin98.xml,v 
<--  pvcsWin98.xml
new revision: 1.39.4.2; previous revision: 1.39.4.1
done
Checking in pvcsWin98Loc_XX.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsWin98Loc_XX.xml,v 
<--  pvcsWin98Loc_XX.xml
new revision: 1.39.4.2; previous revision: 1.39.4.1
done
Checking in pvcsWinLoc_XX.xml;
/cvs/vcsgeneric/profiles/pvcs/src/org/netbeans/modules/vcs/profiles/pvcs/config/pvcsWinLoc_XX.xml,v 
<--  pvcsWinLoc_XX.xml
new revision: 1.42.4.2; previous revision: 1.42.4.1
done
Comment 10 Jiri Kovalsky 2003-05-23 14:27:33 UTC
Verified in Sun ONE Studio RC5 build #030521 with JDK 1.4.1 build #02
on RedHat Linux 7.2.