This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
This report may be similar to Issue#: 31331, but I've experienced it using both the GUI Style and Default switches UI mode. I have CVS repositories in which I cannot commit or update files in certain directories (while others work fine). I get the following error "protocol error: directory '/cvs/dirbaasses/com/chiinc/smart/gui/drawing' not within root '/cvs/dirba'". The correct repository should be "/cvs/dirba/SMART/src/com/chiinc/smart/gui/drawing". I can commit/update the problem files from the same local directory just fine using winCVS, so it seems the error is internal to netbeans and not in the generated cvs related files.
Are you sure that your WinCVS and NetBeans use exactly the same cvs.exe binary ? Can you attach here _complete_ execution string of failing commands and their _complete_ outputs ? I bet this is some "incorrect settings" issue that can't be reproduced from empty working directory.
Issue #31331 does not seem to be related with this. - Do you use built-in cvs client or command-line cvs client? It would be valuable if you can attach the execution string and output of the failed command. You will find this on the Runtime tab under "VCS Commands" node. Also please look into CVS/Repository file in your working directory if it contains correct information.
I'm using the built in cvs client, so I'm sure winCVS and netbeans are using different cvs executables. The CVS/Repository file contained the correct information (that was the first place I looked to try to resolve the problem). I'm currently away from the computer which contains my netbeans 3.5 beta installation, but I will attach the execution string and output of the failed command when I get back to that machine tomorrow.
Moving to javacvs module. Since you're using the built-in client, I'm not sure whether the execution string will help. Do you have the filesystem correctly customized? What the Repository field is? Also did you import the project with CVS filesystems from NB 3.4.x build or did you mount a new CVS filesystem in NB 3.5? Valuable would be to have the log of the communication with CVS server. Please start the IDE with arguments like: runide.exe -J-DcvsClientLog=c:\temp\mycvslog and attach the generated mycvslog.in and mycvslog.out files.
I'm sorry, but we're not able to reproduce the problem. Is this reproducible for you with the newly mounted CVS filesystem as well? Resolving as worsforme till you provide more data to localize the problem.
Created attachment 10147 [details] mycvslog.in for imported project from 3.4.1
The filesystem is properly customized (I've checked it several times). I imported the project from 3.4.1 and the repository field is /cvs/dirba. However, I also recieve the same error if I mount the repository as new in NB 3.5. Once again, using winCVS in the same local directory works fine. I'm attaching mycvslogs for both the imported and newly created cvs filesystem.
Created attachment 10148 [details] mycvslog.in for imported filesystem
Created attachment 10149 [details] mycvslog.out for imported filesystem
Created attachment 10150 [details] mycvslog.in for newly created filesystem
Created attachment 10151 [details] mycvslog.out for newly created filesystem
Thanks for the loggs! It's apparent, that the bug is on the client side (NetBeans' cvs client) and it's not dependent on whether the filesystem was imported or not. The error is identical. The problematic command seems to be just commit. Instead of SMART/src there is just 'sses' string. I suppose you have 'SMART/src' set as the relative mount point. This might be important to be able to reproduce it. So I'm reopening it again, we need to test it even more...
That's correct, SMART/src is the relative mount point. One thing I haven't mentioned which may be relevant is that I have a second local filesystem mounted (D:\Projects\SMART\code\classes) which I'm using as my compilation target directory. Initially I felt that the error was occurring because of the mangling of the two filesystem names, but I was unable to find any files external to netbeans as the cause. I haven't had the chance (or familiarity with the netbeans code) to go digging around in the source. Just to reiterate something I mentioned earlier, I only get this error when trying to commit/update files which reside in some of my packages (SMART\src\com\chiinc\smart\datamodel\planspecs and SMART\src\com\chiinc\smart\gui\drawing) while others continue to work correctly. Another thing I found strange was the appearance of the text "I LOVE YOU" in both log files.
> Another thing I found strange was the appearance of the text "I LOVE > YOU" in both log files. :-) Yes, we love our users :-) Seriously: this is a part of the cvs protocol. This way the server let the client to know, that the password is valid and was accepted. So this text was send from your cvs server. Thanks for the update. It's very strange, that this problem appears only in some folders and not in others. Thanks for mentioning the presence of the local filesystem, which is used as the target. The strange string 'sses' might come from 'classes'. I will try to reproduce it...
I was able to reproduce the problem. The key thing seems to be the presence of the second local filesystem used as compilation target directory.
The problem is fixed in the main trunk. Files, that do not belong to the CVS filesystem are ignored: /cvs/javacvs/src/org/netbeans/modules/cvsclient/actions/JavaCvsActionSupporter.java,v <-- JavaCvsActionSupporter.java new revision: 1.8; previous revision: 1.7
Created attachment 10161 [details] The binary patch. Put into <NB-install>/modules/patches/org-netbeans-modules-cvsclient/ folder.
The binary patch, that fix this problem is attached. Please verify that it really solves the problem. (Also verify whether the patch was correctly applied in the ide.log). Thanks.
Created attachment 10162 [details] The contextual diff, that fix this problem.
*** Issue 33160 has been marked as a duplicate of this issue. ***
Code reviewed without objections.
working on verification....
OK on WinXP and Nevada #030408, jdk1.4.1_02
approved for 3.5
Thanks for the review, verification and approval. The bug is fixed in release35 branch: /shared/data/helm/cvs/repository/javacvs/src/org/netbeans/modules/cvsclient/actions/JavaCvsActionSupporter.java,v <-- JavaCvsActionSupporter.java new revision: 1.7.30.1; previous revision: 1.7
oups.... of'course | didn't verify on the specified build! It is typo. I tested and verified on build #030424_1 with provided binary patch