This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
TopComponent org.netbeans.core.output.OutputTabTerm provides CloneViewAction but does not implement TopComponent.Cloneable interface.
Original issue #33110
Which way should this be solved? - Don't provide the actions - Add support for cloning the view I think cloning an output window is probably pretty useless for the user, so I'm inclined to support option 1. Cc'ing Jan Rojcek for HIE input.
IMO, the Clone View action shouldn't be available for the Output Tab. This needs to be fixed for 3.5/S1S5... -> P1.
Fixed in trunk, org.netbeans.core.output.OutputTabTerm.java version 1.7. I removed the Clone action from the array of actions returned by SystemAction. It would not be possible to implement TopComponent.Cloneable on OutputTabTerm, since it is a public class and that would be an incompatible change. Also, the clone action on output windows is quite useless and shouldn't be exposed to the user in the first place, IMO. The real bug may be in TopComponent - it supplies the clone action whether or not the instance implements TopComponent.Cloneable. Since docking actions and such appear in the menu, it appears that the system menu contents may be altered by other code, so it doesn't seem safe to make a global change to TopComponent to fix this issue, especially not if we are considering the fix for 3.5. I have filed issue 33129 regarding this.
Created attachment 10073 [details] Binary patch of the fix
Created attachment 10074 [details] Patch to OutputTabTerm
I reviewed fix and it is OK. Winsys adds its own actions (Docking action in this case) to existing actions provided by TopComponent.getActions() when popup on tab is created.
patch verified
approved for 3.5
Integrated into 3.5.
verified in [nb3.5](2003042350)
As issue #33557 is fixed (TopComponent does not provide CloneViewAction when it does not implement TopComponent.Cloneable interface in trunk.) it is possible to remove workaround in trunk. /cvs/core/output/src/org/netbeans/core/output/OutputTabTerm.java,v <-- OutputTabTerm.java new revision: 1.10;
moving terminal emulator issues to terminalemulator component. To see the correct version and target milestone of this issue look at Issue Activity table.