This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 32802 - IOException after restart IDE with opened file with different then last version(cvs)
Summary: IOException after restart IDE with opened file with different then last versi...
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: -S1S-
Hardware: All All
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-10 17:10 UTC by Lukas Hasik
Modified: 2003-07-08 13:02 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
ide.log with exception (66.67 KB, text/plain)
2003-04-10 17:10 UTC, Lukas Hasik 		Details
The contextual patch, that fix this problem. (1.38 KB, patch)
2003-04-14 16:27 UTC, Martin Entlicher 		Details | Diff
The binary patch. To apply, put into <NB-install>/modules/autoload/patches/org-netbeans-modules-vcscore/ folder. (3.79 KB, application/octet-stream)
2003-04-14 16:30 UTC, Martin Entlicher 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lukas Hasik 2003-04-10 17:10:04 UTC 
Sun ONE Studio 5, Standard Edition (Build 030408)
jdk 1.4.1_02-b06

1, mount cvs filesystem
2, open versioning explorer and open some earlier
version of a file
3, close IDE
4, restart

IOException appears - see my ide.log
Comment 1 Lukas Hasik 2003-04-10 17:10:47 UTC 
Created attachment 9853 [details]
ide.log with exception
Comment 2 mslama 2003-04-11 11:06:52 UTC 
It is NPE from RevisionEditorSupport when TopComponent is deserialized
by winsys.
Comment 3 Martin Entlicher 2003-04-11 15:13:10 UTC 
It's a bug, that Env class is serialized.
Comment 4 Martin Entlicher 2003-04-14 14:37:54 UTC 
Fixed in the main trunk:

/cvs/vcscore/src/org/netbeans/modules/vcscore/versioning/RevisionEditorSupport.java,v 
<--  RevisionEditorSupport.java
new revision: 1.8; previous revision: 1.7

Is this a showstopper?
Comment 5 Jiri Kovalsky 2003-04-14 15:16:11 UTC 
I think that harmless exception is not a showstopper although I know
that fix is straightforward. What do others think ? Lukasi, Dane,
Mariane ?
Comment 6 Martin Entlicher 2003-04-14 15:25:47 UTC 
The fix is really trivial and 100% safe. There should be some
mechanism to get trivial fixes into the release although they're not
real showstoppers. The criterium should be the safety of the fix IMHO.
Trung, what's your opinion on this?
Comment 7 Lukas Hasik 2003-04-14 15:55:52 UTC 
increasing to P1 to get the fix to the release.

why should we frighten users with exception when we don't have to.
Comment 8 Marian Mirilovic 2003-04-14 15:57:35 UTC 
Ok, I agree with integration to 3.5.

Martin, please attach the fix, we will test it, thanks.
Comment 9 Martin Entlicher 2003-04-14 16:27:44 UTC 
Created attachment 9924 [details]
The contextual patch, that fix this problem.
Comment 10 Martin Entlicher 2003-04-14 16:30:35 UTC 
Created attachment 9925 [details]
The binary patch. To apply, put into <NB-install>/modules/autoload/patches/org-netbeans-modules-vcscore/ folder.
Comment 11 Richard Gregor 2003-04-14 16:34:05 UTC 
Code reviewed without objections.
Comment 12 Jiri Kovalsky 2003-04-14 16:38:47 UTC 
Seems good here. No exception thrown, I agree.
Comment 13 Lukas Hasik 2003-04-14 16:58:30 UTC 
patch verified.
Comment 14 _ ttran 2003-04-15 10:58:48 UTC 
approved for 3.5
Comment 15 Martin Entlicher 2003-04-15 12:33:56 UTC 
Thanks for the review, verification and approval. The fix is merged
into release35 branch:

Checking in
org/netbeans/modules/vcscore/versioning/RevisionEditorSupport.java;
/shared/data/helm/cvs/repository/vcscore/src/org/netbeans/modules/vcscore/versioning/RevisionEditorSupport.java,v 
<--  RevisionEditorSupport.java
new revision: 1.7.2.1; previous revision: 1.7
done
Comment 16 Jiri Kovalsky 2003-07-08 13:02:16 UTC 
Cool, no exception is thrown. Verified in Sun ONE Studio 5.0 Standard
Edition build #030528.