This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 32404 - Consider separation of old window system implementation
Summary: Consider separation of old window system implementation
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: PC All
: P3 blocker (vote)
Assignee: Peter Zavadsky
URL:
Keywords:
Depends on:
Blocks: 24888 29836
  Show dependency tree
 
Reported: 2003-03-27 14:57 UTC by Peter Zavadsky
Modified: 2008-12-23 12:30 UTC (History)
4 users (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Zavadsky 2003-03-27 14:57:59 UTC
Like issue #32403, try to separate also old window
system implementation.

It's Marek's idea: In that case if new window
system will be used, but some platform users wont
be satisfied with the fact of disappearing
floating windows, workspaces, SDI/MDI modes etc.
They will have to possibility switch to older
behaviour.
Comment 1 mslama 2003-04-16 10:52:56 UTC
Assigning to Peter.
Comment 2 Peter Zavadsky 2003-04-28 16:55:19 UTC
Separating of older winsys seems to be more complicated. There is
dependency from NbMainExplorer to DeferredPerformer, which depend on
StateManager. Those classes I'd like to remove completelly and not
remain in core.
Will try to remove the deferred performer calls from NbMainExplorer as
Marek suggested.
Comment 3 Peter Zavadsky 2003-04-28 17:41:32 UTC
Created branch separation_32404.

It is rooted to tag BLD2003040280100.

Instructions for build:
1) Checkout all but core with tag BLD200304280100
2) Checkout core with separation_32404
3) Build and run.

Comment 4 Peter Zavadsky 2003-04-29 09:08:08 UTC
Branched also nbbuild and projects modules with the same parameters.
Comment 5 Peter Zavadsky 2003-04-29 16:39:54 UTC
So to sum it up. Instructions:

1) Checkout all except core, nbbuild and projects moduel with
BLD200304280100 tag.
2) Checkout core, nbbuild, projects with separation_32404 tag.
3) Build and run.


It seem it remains to play with tests a bit and it should be more/less
done.

I didn't move some of the things to core/ui (there is dependency on
NbMainExplorer in modules NodeManifestSection...).

Comment 6 Peter Zavadsky 2003-04-30 12:26:25 UTC
I moved the test to core/windows (need to ask L.Martinek how to add
them to default tests).

Also core/deprecated project saving is enabled.

Also core/deprecated and core/output were made independent from
core/windows.
Comment 7 Jesse Glick 2003-05-01 00:57:14 UTC
Let's see, some obvious problems (just checked out and built branch,
then started it on a fresh user dir):

1. Explorer window not open (probably due to Editing.wswksp not
found). View -> Filesystems opens it in a separate window. After
moving that into the MDI frame, View -> Runtime docks correctly, but
View -> Projects opens in another separate window.

2. MRE when trying to open Properties window.

3. MW toolbars appear to be too high, I think - too much padding. Not
sure if I'm imagining things, but I thought they used to be smaller.
May be nothing, but check relative to another dev build.

Otherwise looks OK, I think.

Relevant exceptions:

java.io.FileNotFoundException: JAR entry
org/netbeans/core/ui/resources/windowmanager/Editing.wswksp not found
in /dev/shm/separation_32404/nbbuild/netbeans/modules/core-ui.jar

java.util.MissingResourceException: Can't find resource for bundle
org.openide.util.NbBundle$PBundle, key CTL_PropertiesWindow
	at java.util.ResourceBundle.getObject(ResourceBundle.java:314)
	at java.util.ResourceBundle.getString(ResourceBundle.java:274)
	at org.netbeans.core.NbSheet.open(NbSheet.java:188)
Comment 8 Peter Zavadsky 2003-05-02 10:06:23 UTC
First two points should be fixed. (I wrongly updated the old xml
declarations).

The third one. You are ritght, the padding is bigger, I didn't find
out the problem. I guess it has to do somethind with the workspace
switcher and its gui classes which I moved.
Comment 9 Peter Zavadsky 2003-05-02 10:07:59 UTC
The padding is also solved. But it seems the problem is that the
configuration isn't read correctly (therefore some 'default' was set
but there was a but with the padding).

Note:
I also branched openide the same way like the above modules.
Comment 10 Peter Zavadsky 2003-05-02 10:36:43 UTC
Discovered another obvious proble:
Dialogs aren't shown properly (e.g Filesystem Customize, it just flicks).
Comment 11 Peter Zavadsky 2003-05-06 16:41:20 UTC
Branch [separation_32404] merged into [trunk].


Note:
changed modules:
openide, core, projects, nbbuild;

tags:
separation_32404_before_merge,
separation_32404_after_merge.