This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 32237 - Refresh recursively loops
Summary: Refresh recursively loops
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-24 14:14 UTC by tboerkel
Modified: 2003-04-14 16:13 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Loop1 (128.70 KB, image/jpeg)
2003-03-24 14:15 UTC, tboerkel
Details
Loop2 (83.13 KB, image/jpeg)
2003-03-24 14:16 UTC, tboerkel
Details
Loop3 (64.65 KB, image/jpeg)
2003-03-24 14:45 UTC, tboerkel
Details
Loop4 (130.91 KB, image/jpeg)
2003-03-24 15:15 UTC, tboerkel
Details
Context diff, that fix this problem. (984 bytes, text/plain)
2003-03-26 16:21 UTC, Martin Entlicher
Details
The binary patch, that fixes this issue. (7.00 KB, application/octet-stream)
2003-03-26 16:24 UTC, Martin Entlicher
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tboerkel 2003-03-24 14:14:43 UTC
This happens in the latest Q-Build
(NetBeansIDE-release35-QBE200303182350-200303202210.zip),
using JDK 1.4.1_02 and VSS 6.0d.
I had used this directory with 3.4.1 and switched
now to 3.5dev. To update the VCS cache, which I
suspect is different in 3.5, I did a Refresh
Recursively.
First try: Loop1.jpg. I stopped it and tried
again: Loop2.jpg.
Seems reproducable.
Comment 1 tboerkel 2003-03-24 14:15:36 UTC
Created attachment 9499 [details]
Loop1
Comment 2 tboerkel 2003-03-24 14:16:09 UTC
Created attachment 9500 [details]
Loop2
Comment 3 tboerkel 2003-03-24 14:45:25 UTC
Creating a new attachment (Loop3) from the start of the refresh
commando, maybe useful. Tried after a restart of NB.
Comment 4 tboerkel 2003-03-24 14:45:52 UTC
Created attachment 9501 [details]
Loop3
Comment 5 Jiri Kovalsky 2003-03-24 15:02:42 UTC
I am gonna check this now ... stay tuned.
Comment 6 tboerkel 2003-03-24 15:12:22 UTC
Correction: It does not loop, but it takes very very long. Attaching
screenshot from the end (Loop4.jpg).
Comment 7 tboerkel 2003-03-24 15:15:20 UTC
Created attachment 9502 [details]
Loop4
Comment 8 Jiri Kovalsky 2003-03-24 15:58:27 UTC
This is very strange bug and looks totally unprofessional. This must
be definetely fixed into Sun ONE Studio 5.0 and NetBeans 3.5. Thus
increasing priority - this is showstopper !
Comment 9 Martin Entlicher 2003-03-24 16:01:16 UTC
The cache format is the same, but there were some problems with
missing statuses etc. which can be corrected with the Recursive
Refresh.

The result looks really odd, I agree that this is necessary to fix
into 3.5. I'll work on a fix in the main trunk in the first place.
Comment 10 Martin Entlicher 2003-03-25 16:24:36 UTC
I've reproduced it, the problem is, that Refresh command returns every
folder twice. It's not a bug of RetrievingDialog.
On the Empty profile the Rec. Refresh works O.K.
Comment 11 Martin Entlicher 2003-03-25 16:59:00 UTC
The problem was found and fixed in CommandLineVcsDirReader:

/cvs/vcscore/src/org/netbeans/modules/vcscore/cmdline/CommandLineVcsDirReader.java,v 
<--  CommandLineVcsDirReader.java
new revision: 1.28; previous revision: 1.27

It reported every refreshed file twice - one from passed filesByNames
table and once from the data output listener. The data output listener
should be used for information only.

Please verify in the development builds (20030326 and newer).
Comment 13 _ ttran 2003-03-26 14:04:12 UTC
Martin, if you want to get the fix in release35, please prepare a diff
against that branch _and_ binary patch.  Attach them here so ppl can
review the diff and test the patch.  Thx
Comment 14 Martin Entlicher 2003-03-26 16:21:18 UTC
Created attachment 9543 [details]
Context diff, that fix this problem.
Comment 15 Martin Entlicher 2003-03-26 16:24:51 UTC
Created attachment 9544 [details]
The binary patch, that fixes this issue.
Comment 16 Martin Entlicher 2003-03-26 16:26:01 UTC
The binary patch attached.
To apply: create folder patches/org-netbeans-modules-vcscore in
modules/autoload in the NetBeans 3.5 installation directory and copy
the attached Patch32237.jar into that folder:

cp Patch32237.jar \
netbeans/modules/autoload/patches/org-netbeans-modules-vcscore

Then restart NetBeans.
Comment 17 Jiri Kovalsky 2003-03-27 13:15:22 UTC
Wonderful, I have just verified the fix using supplied patch in
development build #030326 of Sun ONE Studio 5.0. It's a "Go" from QA.
Comment 18 Tomas Pavek 2003-03-27 17:35:25 UTC
The fix is quite simple. Diff looks ok for me.
Comment 19 _ ttran 2003-03-28 08:07:47 UTC
approved by release coordinator for 3.5
Comment 20 Martin Entlicher 2003-03-28 16:29:14 UTC
Thanks for the review and approval, it's merged into release35 branch:

/shared/data/helm/cvs/repository/vcscore/src/org/netbeans/modules/vcscore/cmdline/CommandLineVcsDirReader.java,v 
<--  CommandLineVcsDirReader.java
new revision: 1.27.2.1; previous revision: 1.27
Comment 21 Jiri Kovalsky 2003-04-14 16:13:27 UTC
Verified in development build #200304132350 of NetBeans 3.5.