This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 32115 - Can't add a servlet to CVS repository
Summary: Can't add a servlet to CVS repository
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: -S1S-
Hardware: PC Windows ME/2000
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-19 03:47 UTC by John Baker
Modified: 2003-03-20 14:30 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
If useful, here's the Web App I used (50.37 KB, application/octet-stream)
2003-03-19 03:48 UTC, John Baker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Baker 2003-03-19 03:47:05 UTC
Using kit 030317_2 on Win 2K , J2SE 1.4.0_03

To reproduce:

1) Mount a new local, new CVS workspace
2) Convert this filesystem to a web module
3) Create a package under WEB-INF/Classes
4) Create a servlet in this package
5) Select servlet and do a CVS add

Output window says I must do a checkout first

6) Do CVS checkout on the filesystem
7) Select package under WEB-INF/Classes and do a
CVS add
(seems ok)
8) Repeat step 5

Again, Output window says I must do a checkout first

Full output says:
"cvs checkout: cannot find module
`WEB-INF/classes/servlet/MyServlet.java' - ignored"

Also, I don't see any badges next to the servlet and
every CVS action I try results in an error.
Comment 1 John Baker 2003-03-19 03:48:43 UTC
Created attachment 9454 [details]
If useful, here's the Web App I used
Comment 2 Martin Entlicher 2003-03-19 12:56:46 UTC
The problem is, that you didn't add "WEB-INF" folder and "Classes"
folder.

> 7) Select package under WEB-INF/Classes and do a CVS add
> (seems ok)

This is a problem. It seems O.K., but it's not. The add command fails
in fact. It must fail, because the parent directories are not added.

So there are two problems that I've found while reproducing this:
1) Add command fails, but it says, that it finished (natural
implication is, that it finished successfully, but it's not true)
2) After you convert the CVS FS to web module, no commands are added
into Runtime tab.
Comment 3 Jiri Kovalsky 2003-03-19 16:06:47 UTC
Well, I was able to convert the filesystem, add everything into
repository but Martin is right about non functioning commands history.
This is significant bug and must be fixed into S1S 5.0 FCS.
Please be aware that this issue is Q-Build showstopper and must be
fixed soon.
Comment 4 Marian Mirilovic 2003-03-19 17:29:56 UTC
This issue is Q-build stopper (200303182350) and must be fixed into
branch "release35-QBE-200303182350) too, thanks in advance.
Comment 5 Martin Entlicher 2003-03-19 20:51:55 UTC
The problem of commands history in Runtime tab is fixed in the main trunk:

/cvs/vcscore/src/org/netbeans/modules/vcscore/commands/CommandProcessor.java,v
 <--  CommandProcessor.java
new revision: 1.11; previous revision: 1.10

/cvs/vcscore/src/org/netbeans/modules/vcscore/runtime/RuntimeCommandsProvider.java,v
 <--  RuntimeCommandsProvider.java
new revision: 1.6; previous revision: 1.5
/cvs/vcscore/src/org/netbeans/modules/vcscore/runtime/RuntimeMainChildren.java,v
 <--  RuntimeMainChildren.java
new revision: 1.13; previous revision: 1.12
/cvs/vcscore/src/org/netbeans/modules/vcscore/runtime/VcsRuntimeCommandsProvider.java,v
 <--  VcsRuntimeCommandsProvider.java
new revision: 1.7; previous revision: 1.6

Please verify in the dev build.

The problem with "finished" Add does not seem to me that important.
Only the Add command is affected. If this needs to be ever fixed,
please file a separate issue with a lower priority.
Comment 6 Jiri Kovalsky 2003-03-20 12:27:36 UTC
Great, verified in my own trunk build of NetBeans 4.0 #030320. Please
integrate the fix into release35 branch too.
Comment 7 Martin Entlicher 2003-03-20 14:25:31 UTC
Merged into release35 branch:

/cvs/vcscore/src/org/netbeans/modules/vcscore/commands/CommandProcessor.java,v 
<--  CommandProcessor.java
new revision: 1.8.2.2; previous revision: 1.8.2.1

/cvs/vcscore/src/org/netbeans/modules/vcscore/runtime/RuntimeCommandsProvider.java,v 
<--  RuntimeCommandsProvider.java
new revision: 1.5.2.1; previous revision: 1.5
/cvs/vcscore/src/org/netbeans/modules/vcscore/runtime/RuntimeMainChildren.java,v 
<--  RuntimeMainChildren.java
new revision: 1.12.2.1; previous revision: 1.12
/cvs/vcscore/src/org/netbeans/modules/vcscore/runtime/VcsRuntimeCommandsProvider.java,v 
<--  VcsRuntimeCommandsProvider.java
new revision: 1.6.36.1; previous revision: 1.6
Comment 8 Martin Entlicher 2003-03-20 14:30:26 UTC
Merged into release35-QBE200303182350 branch:

Checking in commands/CommandProcessor.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/commands/CommandProcessor.java,v 
<--  CommandProcessor.java
new revision: 1.8.2.1.6.1; previous revision: 1.8.2.1
done
Processing log script arguments...
More commits to come...
Checking in runtime/RuntimeCommandsProvider.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/runtime/RuntimeCommandsProvider.java,v 
<--  RuntimeCommandsProvider.java
new revision: 1.5.8.1; previous revision: 1.5
done
Checking in runtime/RuntimeMainChildren.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/runtime/RuntimeMainChildren.java,v 
<--  RuntimeMainChildren.java
new revision: 1.12.8.1; previous revision: 1.12
done
Checking in runtime/VcsRuntimeCommandsProvider.java;
/cvs/vcscore/src/org/netbeans/modules/vcscore/runtime/VcsRuntimeCommandsProvider.java,v 
<--  VcsRuntimeCommandsProvider.java
new revision: 1.6.42.1; previous revision: 1.6
done