This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
When I pick a file in a directory and tell it to update, all files in that directory appear to get updated. They loose their icons, but actually only the 1 files gets updated. dev build 200303070100 jdk 1.3.1_07
We need to investigate what's wrong with update command or updating of statuses. Scheduled for 4.0
<POLITICS=ON> I think this should be scheduled for 3.5. this is a heidously ugly bug that will immediately draw the wrath of any that use CVS. The bug is too prominent to really be on the back burner. In the auto industry we have what we call Failure Modes and Effects Analysis (FEMA). We rate problems on several things severity occurance detection each of these is rated on a scale of 1 to 10 and then multiplied out to get the final number. So sometimes problems with low severity have high occurance, or detection and thus end up high priority anyway. I think this is just one such case. The severity of the bug is minimal, but the occurance is frequent, and the detection is absolute. It looks bad, and it looks bad frequently. Its going to be frustrating to me to use a "released" edition of the IDE and have the CVS statuses frequently wrong. I'm not going to change the settings myself, because I don't know the rest of the bugs against this module and where this one falls in the ranks, but I sincerely hope a strong effort is given to solve this highly visible one. </POLITICS>
CVS is just doing something foul. The folder seems to be closing and reopening, or the file is disappearing then reappearing. The selected node is being changed. The update issue does not appear when updating files that were deleted. I have not figured out how to put files in a position to need updating in order to test this bug. Im filing another one on the strange behavior of CVS commands... BLD200303110100
I'm not so sure this is a vcscore bug either. More of a windowing system/JTree issue. Its dangerous.
Richarde, can you please investigate this issue a little bit furhter ? Thanks.
Well, my opinion about this is that true bug is that data node is not reloaded after it is deleted. On the other hand Update command does it which results in what you are describing. This must be definetely fixed because it's a regression. However it needs more investigation, so please be patient. BTW, what do you mean by "gets updated" ? Is it just change of icon and/or status or it really gets cvs updated and becomes [Up-to-date] ? Thanks for cooperation.
The file that I tried to Update, actually does get updated in the CVS sense of the word. The rest of the files in the directory that require updating, appear to get updated as well. Meaning they loose the dot that signifies needing updating, but I don't recall if text is changed as well(I think it is). Upon refresh, the dot comes back and you realize that only 1 file was updated(in the CVS sense of the word.)
Okay, I am glad to hear that, because I was afraid that also other files were cvs updated = created physically in case they were in [Needs Update] state. Do you confirm, that deletion did not replace node's icon with blank sheet one ?
Deletion does eventually replace the icon with a blank sheet. Its ashame this does not happen immediately as it obviously should. Sometimes I have to do a refresh to get this. The time to wain on it is also quite random. So you can forget delete-update as a means of getting a clean copy of a file because its more likely that 3 out of 10 times you will need delete-refresh-update... The icons just behave strangely lately and I file another bug on that Issue #31957
Tomas, could you please look on it?
*** Issue 31957 has been marked as a duplicate of this issue. ***
If this will involve the issue of rebuilding the whole tree because 1 node changed, changine my selection and other side effects, the target should be 3.5, and the priority should probably be P1. It certainly is a regression.
Thanks to Tomas this is fixed in the main trunk: http://www.netbeans.org/source/browse/vcscore/src/org/netbeans/modules/vcscore/VcsFileSystem.java.diff?r1=1.213&r2=1.214 It was verified by Jiri in the main trunk and I'm going to merge the fix into the release35 branch.
Fixed in release35 branch: /cvs/vcscore/src/org/netbeans/modules/vcscore/VcsFileSystem.java,v <-- VcsFileSystem.java new revision: 1.207.2.5; previous revision: 1.207.2.4
I must disagree with the fix because I have just understood what dnoyeB meant. When updating a file in a folder with another [Locally Modified] file all files got [Up-to-date] status. Manual refreshing corrects it but it must not happen. Martin you saw this behavior can you please fix this ? The issue with dataloaders is okay. Trying to verify in build #030323 of Sun ONE Studio 5.0.
O.K., so Tomas' fix was more like a fix of issue #31957. The problem seems to be in CvsUpdate command.
It is fixed in the main trunk: /cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsUpdate.java,v <-- CvsUpdate.java new revision: 1.7; previous revision: 1.6 Diff: http://www.netbeans.org/source/browse/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsUpdate.java.diff?r1=1.6&r2=1.7
Created attachment 9545 [details] Diff with respect to the release35 branch.
Created attachment 9546 [details] The binary patch that fix this issue.
The binary patch attached. To apply: create folder patches/org-netbeans-modules-vcs-profiles-cvsprofiles in "modules" folder in the NetBeans 3.5 installation directory and copy the attached Patch31799.jar into that folder: cp Patch31799.jar \ netbeans/modules/patches/org-netbeans-modules-vcs-profiles-cvsprofiles Then restart NetBeans.
Great, I have just verified the fix using supplied patch in development build #030326 of Sun ONE Studio 5.0. Looks like no regression happens. I agree with integration into product branch.
still waiting for code review...
The diff looks ok to me. I see no problems.
approved by release coordinator for 3.5
Thanks for the review and approval. It's fixed in release35 branch: /cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/commands/CvsUpdate.java,v <-- CvsUpdate.java new revision: 1.6.2.1; previous revision: 1.6
OK in NB35 #200306022350