This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 31381 - Provide an option to turn on "display contents" in "Position within the file"
Summary: Provide an option to turn on "display contents" in "Position within the file"
Status: RESOLVED DUPLICATE of bug 33717
Alias: None
Product: utilities
Classification: Unclassified
Component: Search (show other bugs)
Version: 3.x
Hardware: All All
: P3 blocker (vote)
Assignee: Marian Petras
URL:
Keywords: UI
Depends on:
Blocks:
 
Reported: 2003-02-23 23:32 UTC by _ mihmax
Modified: 2003-08-04 12:45 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
3.4.1 (Russian) behaviour (18.50 KB, image/png)
2003-02-23 23:35 UTC, _ mihmax
Details
3.5 dev (trunk) behaviour (18.62 KB, image/png)
2003-02-23 23:36 UTC, _ mihmax
Details

Note You need to log in before you can comment on or make changes to this bug.
Description _ mihmax 2003-02-23 23:32:29 UTC
In NetBeans 3.4.x Find-in-Files tool was useful:
 when I searche for some string I didn't have to
open each file to see, if the file is really what
I seek, I simply positioned a mouse over one of
the lines in "Position within the file" list and
the hint showed 
[<filename> on xx:yy] The whole line, matched the
search str

Now (3.5 dev built from trunk) it shows 
line xxx, column yyy

Screenshots follow
P2 because it's regression
Comment 1 _ mihmax 2003-02-23 23:35:29 UTC
Created attachment 9109 [details]
3.4.1 (Russian) behaviour
Comment 2 _ mihmax 2003-02-23 23:36:02 UTC
Created attachment 9110 [details]
3.5 dev (trunk) behaviour
Comment 3 Marian Petras 2003-02-24 10:47:32 UTC
This is NOT a bug. I had a choice - either let bug #28518 (Tooltip
text is confused in 'Search Results' dialog) unresolved or make a
change so that tool tips do not display found segments of texts. I
have chosen to make a change for two reasons:
  - tooltips should serve as hints, not as a main source of
    information
  - if the matching file was a binary file (which is another issue
    - #23584 "search filesystem should not search binary / class
    files"), a very wide tooltip full of garbage would be displayed

The dialog for displaying search results should be redesigned so that
it displays found strings in another way then in tooltips (see issue
#7311 "Find Results dialog should show matching text lines").

For now, it is always possible to press button "Show All Details" and
let the matching strings be displayed in the output window.
Comment 4 _ mihmax 2003-02-24 11:03:09 UTC
OK, I reformulate the question,

Could you please provide an option (off by default) to 
turn this nice tooltip (I'm used to it much ;-) ON to 
display file's contents in a hint over each line 
in "Position within the file" subwindow.?

(WAS: Regression: [Find tool] "Position within the file" 
is useless)
Comment 5 Marian Petras 2003-02-24 11:15:22 UTC
If time permits...

Hint: Add a vote to this issue if you want it so much to be
implemented. When I start implementing enhancements, I will take
number of votes into consideration.
Comment 6 _ mihmax 2003-02-24 11:23:57 UTC
Reporter = The only voter isn't amusing much, 

I did vote once, when I filed the issue, but if you like 
voting, I may create a hundred netbeans.org accounts 
(mihmax_00 - mihmax_99 ;-) and vote for this issue.
Comment 7 _ mihmax 2003-02-24 11:35:02 UTC
BTW: If utilities module has a support for options, you 
may point me to:

- CVS logs (to know the changed bits, when you removed 
this support from trunk)
- UtilitiesOptionsSupport class (or whatever it's name is)

And I may implement this thing myself.

The problem with options is that I'm not a guru-NetBeans 
coder, and I can't create a Settings support class. But if 
you are aware of nice docs, I may try to create one. I see 
Settings.java and SettingsBeanInfo.java in utilities/pdf, 
maybe they can act as a starting point.
Comment 8 Marian Petras 2003-02-24 13:24:01 UTC
I have added a support for options just last Friday. I made the
settings project-related (i.e there is one instance of settings per
project). I think option "Display found text in a tooltip" should not
be project-related.
   So you will have to create a new class for options (because a
single class may contain either a group of project-related or a group
of not-project-related options, a mix is not possible).
   I can point to two sources of information:

- http://www.netbeans.org/download/apis/
   - section Options API
   - section Services & Lookup API
- implementation of another options - e.g. in the Utilities module:
    utilities/src/org/.../search/SearchProjectSettings.java
         [new]
    utilities/src/org/.../search/SearchProjectSettingsBeanInfo.java
         [new]
    utilities/src/org/.../search/res/SearchProjectSettings.settings
         [new]
    utilities/src/org/.../utilities/Layer.xml
         [to be modified - find string "Project Settings [Search]"]

Do not forget to add new strings to Bundle.properties (in the above
example, strings with keys
"Services/org-netbeans-modules-search-SearchProjectSettings.settings"
and "TEXT_Search_settings" had to be added).

Btw. most issues do not have a single vote so one vote does make a
difference.
Comment 9 _ mihmax 2003-08-03 19:24:27 UTC
Marian,
after long debates on nbdev/nbdiscuss I came to a conclusion, that
good defaults (even w/o any option to change them) are better than
lots of options, 

so I propose to close this issue and add another one, depending on
#23584 - "when searching text files, tooltip should show a matched
line", if you agree, please close this issue.
Comment 10 Marian Petras 2003-08-04 10:20:45 UTC
I agree with your conclusion (defaults vs. options) but I disagree
about closing a new issue. Displaying matching lines in tooltips is
just another possible solutions of bug #33717 ("Find: should show the
matching text").

So I suggest to close this issue and add a comment to issue #33717
that using tootips is yet another possible solutions.
Comment 11 Marian Petras 2003-08-04 10:25:26 UTC
Correction: ... I disagree about *creating* a new issue ...
Comment 12 _ mihmax 2003-08-04 12:45:16 UTC

*** This issue has been marked as a duplicate of 33717 ***