This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 31244 - Templates submenu appers under Mount menu item
Summary: Templates submenu appers under Mount menu item
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Explorer (show other bugs)
Version: 3.x
Hardware: Sun SunOS
: P1 blocker (vote)
Assignee: Jiri Rechtacek
URL:
Keywords: T9Y
Depends on:
Blocks: 31259
  Show dependency tree
 
Reported: 2003-02-20 07:39 UTC by Jiri Skrivanek
Modified: 2008-12-22 22:49 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Screen shot. (25.40 KB, image/jpeg)
2003-02-20 07:58 UTC, Jiri Skrivanek
Details
a proposed patch (9.07 KB, patch)
2003-02-20 16:56 UTC, Jiri Rechtacek
Details | Diff
a patch wich fires too (9.74 KB, patch)
2003-02-20 17:59 UTC, Jiri Rechtacek
Details | Diff
same as better_patch but uses synchronized (9.99 KB, patch)
2003-02-21 07:35 UTC, Jiri Rechtacek
Details | Diff
patch jar to assure in GUI test (77.12 KB, application/octet-stream)
2003-02-24 14:38 UTC, Jiri Rechtacek
Details
Thread dump at dumb time. (12.63 KB, text/plain)
2003-02-24 15:16 UTC, Jiri Skrivanek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Skrivanek 2003-02-20 07:39:04 UTC
In build 200302200100 it started to happen that
templates submenu appears under Mount menu item
invoked on the Filesystems node (see att.). It
happens only in automated tests.
Comment 1 Jiri Skrivanek 2003-02-20 07:58:31 UTC
Created attachment 9052 [details]
Screen shot.
Comment 2 Jan Lahoda 2003-02-20 09:21:17 UTC
Mount action: org.netbeans.core.actions.MountAction. Assigning to
pzavadsky.
Comment 3 Peter Zavadsky 2003-02-20 14:23:44 UTC
Jiri, it is caused by your last commit into ExplorerPanel (1.42). We
have investigated it together with Jiri S.
Comment 4 Jiri Rechtacek 2003-02-20 16:56:42 UTC
Created attachment 9065 [details]
a proposed patch
Comment 5 Jiri Skrivanek 2003-02-20 17:05:34 UTC
Changes in ExplorerPanel also caused that CVS menu item is not
displayed when we open popup menu on a file in CVS filesystem.
Comment 6 Jiri Rechtacek 2003-02-20 17:17:07 UTC
The code in patch moves the DelaySetter from ExplorerPanel direct to
TopComponent. TC.getActivatedNodes can return the acivated node at the
moment (w/o delay).
Comment 7 Jiri Rechtacek 2003-02-20 17:59:52 UTC
Created attachment 9066 [details]
a patch wich fires too
Comment 8 Jiri Rechtacek 2003-02-20 18:01:12 UTC
The better_patch.diff fires the changes of activated nodes, fixes the
problem with cvs menu too.
Comment 9 Jiri Rechtacek 2003-02-21 07:35:33 UTC
Created attachment 9071 [details]
same as better_patch but uses synchronized
Comment 10 Jaroslav Tulach 2003-02-21 10:32:33 UTC
Please, please Jirka, can you write a test for your behaviour? This is
very frigile behaviour and I doubt without describing exactly what we
want from it, we can implement and maintain it correctly.

Anyway I see some problems:
1. there is unsynchronized access to DelayedSetter.nodes
2. I believe that the system will not work correctly with
TC.getLookup() - if I call setActivatedNodes & getLookup().lookup
(Node.class) I will not get right result.

Pretty pretty please with suggar on the top, write a test or we will
never stabilize this code.


Comment 11 Jiri Rechtacek 2003-02-24 14:38:59 UTC
Created attachment 9119 [details]
patch jar to assure in GUI test
Comment 12 Jiri Rechtacek 2003-02-24 14:41:13 UTC
Jirko, pls. assure if the attached jar patch (add to lib/patches)
fixes this defect in your test and add a comment here. Thanks.
Comment 13 Jiri Skrivanek 2003-02-24 15:15:04 UTC
Yes, it works for all known test cases. BUT it makes IDE slower and
slower (see att. thread dump). With previuos patch IDE speed was normal.
Comment 14 Jiri Skrivanek 2003-02-24 15:16:37 UTC
Created attachment 9120 [details]
Thread dump at dumb time.
Comment 15 Jiri Rechtacek 2003-02-25 12:06:33 UTC
the delay was temorary removed, the GUI tests should pass

User: jrechtacek
Date: 03/02/25 04:03:09

Modified:    src/org/openide/explorer ExplorerPanel.java
Log:
hotfix #31244, delay of the activated nodes was temporary removed.
For testing use switch: -J-Dnetbeans.delay.tc=true
(a patch develops on branch issue_31244)
  
Revision  Path
1.43      openide/src/org/openide/explorer/ExplorerPanel.java
Comment 16 Jiri Skrivanek 2003-02-25 14:27:05 UTC
Verified in build 20030225-1214.