This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
When an autoload module is installed via AutoUpdate, the module's XML file will be written like this: ... prolog ... <module name="org.brianlsmith.smn.mdr"> <param name="autoload">true</param> <param name="eager">false</param> <param name="jar">oad/smnmdr.jar</param> <param name="origin">user/autoload</param> <param name="release">1</param> <param name="reloadable">false</param> <param name="specversion">1.0</param> </module> Notice that the "jar" parameter has an "oad/" prefix. The problem is that the code is doing this: if (jarName.startsWith("autoload")) { autoload = true; jarName = jarName.substring("eager"); // <<-- } To me, this problem causes my autoload module to be impossible to install, AFAICT. And, it seems that this code has been in NetBeans since 3.4 release, from looking at the CVS tags. Another problem is that if your module is an eager module, then the XML document will look like: ... <param name="eager">false</param> <param name="jar">/smnmdr.jar</param> <param name="origin">user/eager</param> ... where the "jar" parameter has an extra slash. Another problem is that if your module's jarfile is prefixed with "eager" or "autoload" without a slash ("eagertoplease.jar", "autoloadtest.jar"), they will be incorrectly configured: in the first case, it will be treated as an eager module file named "toplease.jar" and in the latter case it will be treated as an autoload module file named "test.jar". To fix this you need to include the slash in the test (e.g. jarFile.startsWith("eager/")) I gave this Priority=P1 because it seems I cannot release my tool in NBM form until this is fixed. But, I am anxious to see any workaround that is available, particularly one that will work on NetBeans 3.4 release. And, also if this problem _does_ occur in NetBeans 3.4 then I would like to have it nominated for NetBeans 3.4.1
Created attachment 7522 [details] patch to fix reported problems
Fixed in trunk. Brian, thanks for your patch! I'm very sorry about such trivial bug :-( The bug appears only for new autoload or eager module (not presented in updated IDE configuration) which has explicitely set needsrestart=false in nbm's info.xml. Workaround: Set needsrestart=true or omit needsrestart flag in info.xml at all (default is true) Appears also in 3.4, marked as 3.4.1_CANDIDATE
Correcting milestone.
Hi. This issue is marked as 3.4.1_CANDIDATE. It means that it should be integrated into release341 one branch. The plan at http://www.netbeans.org/devhome/docs/releases/34/index.html expected beta1 to be produced on Dec01. That did not happen due to a lot of outstanding not integrated candidates like this one. Would it be possible to spend few minutes by backporting this fix? Thank you in advance.
OK, reassign to Maxym to add patch and integrate into release 341 branch
Ales, is the Brian's bugfix OK? Please, provide a link to your commit Max
Original diff: http://www.netbeans.org/source/browse/autoupdate/src/org/netbeans/modules/autoupdate/SafeModule.java.diff?r1=1.3&r2=1.4
Not sure what "NEW FIXED" means!
Me too, but IssueZilla marks issue as NEW every time it's reassigned, and me and Ales were pinging it ;-) Jesse, have you reviewed the issue? Can you or Ales commit this into release341 branch? Otherwise reassign to me, I'll commit it myself. Sincere Max
Please, consider some time for integrating these issues to release341 branch today (12 Dec 2002), OK?
OK, I'll do it :-)
Integrated into release341 branch
and, hm, CVS log? Ales, you promised ;-)
Sorry, I'm forgetter :-) http://autoupdate.netbeans.org/source/browse/autoupdate/src/org/netbeans/modules/autoupdate/SafeModule.java.diff?r1=1.1&r2=1.1.44.1
verified...