This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 270233 - [PHP7.1] Closing curly brace is not added when nullable types are used
Summary: [PHP7.1] Closing curly brace is not added when nullable types are used
Status: RESOLVED FIXED
Alias: None
Product: php
Classification: Unclassified
Component: Editor (show other bugs)
Version: Dev
Hardware: All All
: P3 normal (vote)
Assignee: junichi11
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-29 01:13 UTC by junichi11
Modified: 2017-04-01 03:14 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description junichi11 2017-03-29 01:13:27 UTC
The closing brace is not added when [Enter] key is pressed after "{".

Reproducible code:

class Foo {

    pubic function test1(): ?string { // [Enter] here

    pubic function test2(?string $string) { // [Enter] here

}

Expected results:

class Foo {

    pubic function test1(): ?string {
        ^
    }

    pubic function test2(?string $string) {
        ^
    }

}

Actual results:

class Foo {

    pubic function test1(): ?string {
        ^

    pubic function test2(?string $string) {
        ^

}
Comment 1 junichi11 2017-03-31 01:05:17 UTC
Fixed.

http://hg.netbeans.org/web-main/rev/15df997b37ce

Thanks.
Comment 2 Tomas Mysik 2017-03-31 04:40:47 UTC
Great job, as always, Thank you!
Comment 3 Quality Engineering 2017-04-01 03:14:19 UTC
Integrated into 'main-silver', will be available in build *201704010002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/15df997b37ce
User: Junichi Yamamoto <junichi11@netbeans.org>
Log: #270233 - [PHP7.1] Closing curly brace is not added when nullable types are used