This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Could you please regenerate signature files for PHP7.1? Thanks!
I should have PHP 7.1 soon I hope (with new version of Kubuntu) so then I will do it. Thanks.
Sigfiles regenerated and improved a bit (using some PHP 7.1 features in some places). http://hg.netbeans.org/web-main/rev/30b1a0e09219 Junichi, please verify this issue (usually, verifying that there is no parsing error from PHP sigfiles is fine; simply start NetBeans with a clean userdir and open any PHP project :) Thanks.
BTW should not we show e.g. "?string" in code completion? What do you think, Junichi? One would immediately see (from the code, no need to have PhpDoc) whether the parameter is nullable or not... Will attach a screenshot for PDO constructor, you will need new PHP signatures from this issue ;) Thanks!
Created attachment 164169 [details] screenshot
(In reply to Tomas Mysik from comment #3) > BTW should not we show e.g. "?string" in code completion? What do you think, > Junichi? One would immediately see (from the code, no need to have PhpDoc) > whether the parameter is nullable or not... BTW I am not sure about it, maybe it is not a good idea at all... Just thinking about it, please, let me know what is your opinion. Thanks!
Sorry, need to reopen this issue and fix the generated sigfiles. I will revert nullable types declaration, it is not correct. Sorry for inconveniences.
(In reply to Tomas Mysik from comment #6) > Sorry, need to reopen this issue and fix the generated sigfiles. I will > revert nullable types declaration, it is not correct. Junichi, because of this, please ignore my question related to code-completion. Thanks.
(In reply to Tomas Mysik from comment #7) > (In reply to Tomas Mysik from comment #6) > > Sorry, need to reopen this issue and fix the generated sigfiles. I will > > revert nullable types declaration, it is not correct. > > Junichi, because of this, please ignore my question related to > code-completion. I see. I've just verified it. Then I also noticed about that :) Thanks.
Should be now fixed properly. Thanks. http://hg.netbeans.org/web-main/rev/810d6f2cbe0b
Verified. It seems that there is no parsing error.(I just rebuilt NB and opened a PHP project. Then checked CC of PDO.) Thanks a lot! Product Version: NetBeans IDE Dev (Build 20170424-810d6f2cbe0b) Java: 1.8.0_121; Java HotSpot(TM) 64-Bit Server VM 25.121-b13 Runtime: Java(TM) SE Runtime Environment 1.8.0_121-b13 System: Linux version 4.4.0-72-generic running on amd64; UTF-8; ja_JP (nb)
Thanks a lot!
Integrated into 'main-silver', will be available in build *201704250002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/30b1a0e09219 User: Tomas Mysik <tmysik@netbeans.org> Log: #270185 - [PHP7.1] Regenerate signature files
Reopening, we now have context-sensitive lexer.
Regenerated, please verify. Thank you! http://hg.netbeans.org/web-main/rev/55271c16284b
Integrated into 'main-silver', will be available in build *201706100001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/55271c16284b User: Tomas Mysik <tmysik@netbeans.org> Log: #270185 cont'd - [PHP7.1] Regenerate signature files
Reopening, @method is generated for every method, this is incorrect, of course. Will fix it. Thanks.
Should be fixed now, please verify, thanks. http://hg.netbeans.org/web-main/rev/eaaeeb9931d9
Integrated into 'main-silver', will be available in build *201706130001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/eaaeeb9931d9 User: Tomas Mysik <tmysik@netbeans.org> Log: #270185 cont'd - [PHP7.1] Regenerate signature files Methods were duplicated, fixed now.
Thank you! Verified. There is no error when a PHP project is opened. Probably, there are no duplicate methods in a CC list. Product Version: NetBeans IDE Dev (Build 201706130001) Java: 1.8.0_131; Java HotSpot(TM) 64-Bit Server VM 25.131-b11 Runtime: Java(TM) SE Runtime Environment 1.8.0_131-b11 System: Linux version 4.4.0-79-generic running on amd64; UTF-8; ja_JP (nb)
Thank you for verification, Junichi!