This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 26887 - SystemAction.iconResource upgrade problem
Summary: SystemAction.iconResource upgrade problem
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Actions (show other bugs)
Version: 3.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: API
Depends on:
Blocks: 29768
  Show dependency tree
 
Reported: 2002-08-29 15:44 UTC by Jesse Glick
Modified: 2008-12-22 17:28 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Proposed 3.4.1 patch (3.04 KB, patch)
2002-11-29 14:32 UTC, Jesse Glick
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2002-08-29 15:44:31 UTC
If possible, make this possible:

package foo.bar;
public class Baz extends SystemAction {
    // ...
    protected String iconResource() {return
"path/to/icon.gif";}
}

where foo/bar/path/to/icon.gif exists. Currently
will look only for path/to/icon.gif. Minor 3.3 ->
3.4 compatibility issue; if cannot be fixed, must
be documented as such.

Workaround: supply a full path prefixed by slash,
e.g.:

package foo.bar;
public class Baz extends SystemAction {
    // ...
    protected String iconResource() {
        return "/foo/bar/path/to/icon.gif";
    }
}

Will produce a warning message in ide.log under
3.4 but should work in both 3.3 and 3.4.
Comment 1 Jesse Glick 2002-09-15 19:00:00 UTC
committed   * Up-To-Date  1.62       
openide/src/org/openide/util/actions/SystemAction.java
added       * Up-To-Date  1.1        
openide/test/unit/src/org/openide/util/actions/SystemActionTest.java
added       * Up-To-Date  1.1        
openide/test/unit/src/org/openide/util/actions/data/someicon.gif
Comment 2 Jesse Glick 2002-11-29 14:32:52 UTC
Created attachment 8113 [details]
Proposed 3.4.1 patch
Comment 3 Jesse Glick 2002-11-29 14:33:33 UTC
Could someone review this patch? Thanks.
Comment 4 Petr Nejedly 2002-12-02 12:28:21 UTC
Seems OK to me
Comment 5 Jesse Glick 2002-12-02 19:02:03 UTC
In release341:

Checking in openide/src/org/openide/util/actions/SystemAction.java;
/cvs/openide/src/org/openide/util/actions/SystemAction.java,v  <-- 
SystemAction.java
new revision: 1.56.20.1; previous revision: 1.56
done
Comment 6 Marian Mirilovic 2003-03-03 14:32:16 UTC
verified
Comment 7 Quality Engineering 2003-07-01 16:34:59 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.