This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 268342 - Deprecate XMLSyntaxSupport over obsolete lexer
Summary: Deprecate XMLSyntaxSupport over obsolete lexer
Status: RESOLVED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: Text-Edit (show other bugs)
Version: Dev
Hardware: PC Linux
: P1 normal (vote)
Assignee: Svata Dedic
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2016-10-04 19:44 UTC by Svata Dedic
Modified: 2016-10-20 01:58 UTC (History)
0 users

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
Proposed changes + module updates (865.84 KB, patch)
2016-10-06 07:37 UTC, Svata Dedic
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Svata Dedic 2016-10-04 19:44:22 UTC
The org.netbeans.modules.xml.text.syntax package uses ancient lexer which is both slow an unmaintained. This package is an API and contains reference to TokenItem etc, so it cannot be really fixed.

New API should be created, which uses the new lexer (or does not expose lexer types at all).

Modules in NB distro should be upgraded to use the new API; the old API should move to a "obsolete" module, which will be injected into build/runtime using module-auto-deps feature.
Comment 1 Svata Dedic 2016-10-06 07:37:33 UTC
Created attachment 162361 [details]
Proposed changes + module updates

Changes proposed to modules:

xml.text -- deprecate / remove obsolete classes, provide alternative API
xml.text.obsolete90 -- new home for obsoleted classes
xml.lexer, xml.catalog -- annotation-based registrations, easier consumable by tests

Implied changes:
xml.schema.completion, web.beans, spring.beans, j2ee.persistence, hibernate -- updated implementation of (mainly) completion to use new API
Comment 2 Svata Dedic 2016-10-18 11:46:01 UTC
Implemented in jet-main#4737d428b104.

I've updated these JEE modules:
* hibernate
* j2ee.persistence
* spring.beans
* web.beans
* jsp.core.syntax

to the new API.
Comment 3 Quality Engineering 2016-10-20 01:58:09 UTC
Integrated into 'main-silver', will be available in build *201610200002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/4737d428b104
User: Svata Dedic <sdedic@netbeans.org>
Log: #268342: Syntax API based on ExtSupport moved to obsolete module; new API created in xml.text, dependent module updated