This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 26176 - Text diff empty after switch from graphical diff
Summary: Text diff empty after switch from graphical diff
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 3.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-08-01 12:39 UTC by rbalada
Modified: 2003-07-01 13:05 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rbalada 2002-08-01 12:39:36 UTC
I tried to run graphical diff (directly from
context menu) an then I switched to to text diff
using combo on top of the form. The textual diff
contained just information about lines where the
change was made.

Text diff from context menu is OK, so the problem
occurs only when switching from graphical diff to
text diff.

found in NetBeans 3.4 RC1
Comment 1 Martin Entlicher 2002-08-01 12:42:21 UTC
The problem is in the parser of cvs diff output. It does not provide
the text of the differences.
The graphical diff does not need the text, but the textual diff does.
Comment 2 Martin Entlicher 2002-08-01 14:20:42 UTC
The fix is simpler that I thought.
The parser already provides the text of the differences, but the
command does not supply it. I had to change the regular expressions so
that the data output of cvs diff command will contain also the text of
the differences. You can fix it yourself ;-)

Fixed in the main trunk.
Diffs:
http://vcsgeneric.netbeans.org/source/browse/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvsUnix.xml.diff?r1=1.14&r2=1.15
http://vcsgeneric.netbeans.org/source/browse/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvsWin.xml.diff?r1=1.14&r2=1.15
http://vcsgeneric.netbeans.org/source/browse/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvsWin98.xml.diff?r1=1.14&r2=1.15
Comment 3 Jiri Kovalsky 2002-08-05 15:08:07 UTC
I am sorry to disappoint you, but it's worse now than before the fix.
Textual diff does not show anything, not even those line numbers. Can
you please investigate it ?
Comment 4 Martin Entlicher 2002-08-05 17:26:45 UTC
I'm sure, that it was not caused by this fix. Thus I'm closing this as
FIXED, because it adds the text content of the differences.

Instead I'm reopening issue #23096, that was submitted for problem
like this.
Comment 5 Jiri Kovalsky 2002-08-06 07:52:18 UTC
In such case I have no objections.
Comment 6 Martin Entlicher 2002-11-08 08:41:26 UTC
Adding 3.4.1_CANDIDATE, this should go into 3.4.1 IMHO.
Comment 7 Jaroslav Tulach 2002-12-03 09:54:16 UTC
Hi. This issue is marked as 3.4.1_CANDIDATE. It means that it should be
integrated into release341 one branch. The plan at
http://www.netbeans.org/devhome/docs/releases/34/index.html expected beta1 to be
produced on Dec01. That did not happen due to a lot of outstanding not
integrated candidates like this one. 

Would it be possible to spend few minutes by backporting this fix? Thank you in
advance.
Comment 8 Martin Entlicher 2002-12-06 12:17:13 UTC
Merged into release341 branch.

/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvsUnix.xml,v 
<--  cvsUnix.xml
new revision: 1.12.18.2.4.2; previous revision: 1.12.18.2.4.1
/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvsWin.xml,v 
<--  cvsWin.xml
new revision: 1.12.18.2.4.2; previous revision: 1.12.18.2.4.1
/cvs/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvsWin98.xml,v 
<--  cvsWin98.xml
new revision: 1.12.18.2.4.2; previous revision: 1.12.18.2.4.1
Comment 9 Quality Engineering 2003-07-01 13:05:10 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.