This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 26024 - Improper use of cookies in JavaDataObject
Summary: Improper use of cookies in JavaDataObject
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Unsupported (show other bugs)
Version: 3.x
Hardware: All All
: P3 blocker (vote)
Assignee: Svata Dedic
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-07-25 21:59 UTC by Rochelle Raccah
Modified: 2007-09-26 09:14 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rochelle Raccah 2002-07-25 21:59:13 UTC
See
<http://www.netbeans.org/servlets/ReadMsg?msgId=354093&listName=nbdev>

Result: There are 2 problems in JavaDataObject's
use of cookies:
1) // ASSERT (klass ==
CompilerCookie.Compile.class)
 return new JCompilerSupport.Compile(entry);

Jesse's comment:
"The assert is not justified, klass may be
anything. If klass is not assignable to any of
CompilerCookie.{Compile,Build,Clean}, but is
assignable to CompilerCookie, null should be
returned."

2) order of the arg/object in the
compile/build/clean checks is backwards

Jesse's comment:
"Yeah I guess it's backwards, please file a bug
ASAP."

Perhaps in addition to this bug, someone should
check the openide and core sources for other
cookie usage errors?
Comment 1 Jaroslav Tulach 2002-07-26 07:58:41 UTC
This bug is reported in version <= 3.4dev and still not fixed. Due to that it
forbids the release candidate for 3.4 to be promoted. Are you aware of that and
are you intensively working on the fix? If not, you should consider some
corrective action.
Comment 2 Svata Dedic 2002-07-26 08:06:52 UTC
This issue was created yesterday around 11:00pm local time.
Unfortunately I need to get some sleep from time to time, so sorry for
not reacting so promptly as you might wish.
Comment 3 Jesse Glick 2002-07-29 02:20:02 UTC
I don't consider this an important bug; it should be fixed soon, but
there is no known visible symptom (and probably will not be any).
Comment 4 Jaroslav Tulach 2002-07-29 09:47:32 UTC
Hi, these issues block the 3.4 release. It has been suggested on nbdev that
those that are not going to be fixed for 3.4 FCS (waivers) change the target
milestone to "future" or "4.0". I'd like to suggest you to do so, if you and
your reporter agree on that.
Comment 5 Svata Dedic 2002-07-29 10:15:38 UTC
Downgrading the prirority; this is not so important to have
significant impact on the 3.4 release and IMHO is not a blocker. I
will fix the issue for 4.0 soon.
Comment 6 Svata Dedic 2003-01-09 11:47:30 UTC
Fixed in trunk,
/cvs/java/src/org/netbeans/modules/java/JavaDataObject.java,v  <-- 
JavaDataObject.java
new revision: 1.164; previous revision: 1.163
Comment 7 Rochelle Raccah 2003-07-16 00:31:51 UTC
Verified in trunk.