This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 25963 - [Explorer DnD] After cancel drop in Explorer popup menu and short cuts don't work there
Summary: [Explorer DnD] After cancel drop in Explorer popup menu and short cuts don't ...
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Explorer (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jiri Rechtacek
URL:
Keywords:
: 26682 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-07-24 12:28 UTC by Marian Mirilovic
Modified: 2008-12-22 19:18 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
a diff (4.22 KB, patch)
2002-09-19 15:06 UTC, Jiri Rechtacek
Details | Diff
jar file with patch (6.18 KB, application/octet-stream)
2002-09-19 15:07 UTC, Jiri Rechtacek
Details
diff for review (8.46 KB, patch)
2002-12-03 13:52 UTC, Jiri Rechtacek
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marian Mirilovic 2002-07-24 12:28:55 UTC
[nb_release34](20020724), [jdk1.4](fcs)

Steps to reproduce:
- run IDE
- select some folder and do "Explore from here"
- select some node in new Explorer view and try to
paste its to Explorer (original view)
- press Esc (cancel) drop
-> now popup menu and short cuts not work in
Explorer (original view)

Everything works fine if you do it in one view ,
but it doesn't work after DnD between different
views. It seems like (again) there are still glass
pane present. 

User must close and reopen Explorer to be possible
use popup menu and short cuts in tree view, so
it's very annoying but DnD betweeen views isn't
often used (if yes we should arise priority).
Comment 1 Jiri Rechtacek 2002-07-24 18:35:32 UTC
This is reproducible only with ExplorerPanel docked in desktop. User
have to select View->Explorer in main menu. Problem is in
getRootPane().getGlassPane() maybe.
Comment 2 Jiri Rechtacek 2002-07-25 17:38:23 UTC
fixed, there is a problem that dragExit event doesn't come if a action
from popup menu is performed. Handling dragExit is responsible for set
original glass pane back to component. The extra handling for this
case was added.
Comment 3 David Simonek 2002-08-26 15:02:10 UTC
*** Issue 26682 has been marked as a duplicate of this issue. ***
Comment 4 Marian Mirilovic 2002-09-18 09:16:23 UTC
It doesn't work again in [nb_dev](20020918).
Comment 5 Jiri Rechtacek 2002-09-19 15:02:56 UTC
fixed, original glass pane is set back and set visible as was
originally. I attached a diff of patch and jar with patch for assure
as 3.4.1_CANDIDATE.
Comment 6 Jiri Rechtacek 2002-09-19 15:06:45 UTC
Created attachment 7456 [details]
a diff
Comment 7 Jiri Rechtacek 2002-09-19 15:07:33 UTC
Created attachment 7457 [details]
jar file with patch
Comment 8 Marian Mirilovic 2002-10-09 10:31:04 UTC
now it doesn't work again in [nb_dev](20021009), [jdk1.4.1](fcs)

It seems like after drop cancelation and try to right-click into
explorer on some node doesn't focus Explorer itself! 
Comment 9 Jiri Rechtacek 2002-10-25 18:33:42 UTC
fixed, the original glass pane is put back when untimely dragDropEnd.
the patch.
Comment 10 Marian Mirilovic 2002-10-30 09:13:46 UTC
verified in [nb_dev](20021030)
Comment 11 Jaroslav Tulach 2002-12-03 09:55:07 UTC
Hi. This issue is marked as 3.4.1_CANDIDATE. It means that it should be
integrated into release341 one branch. The plan at
http://www.netbeans.org/devhome/docs/releases/34/index.html expected beta1 to be
produced on Dec01. That did not happen due to a lot of outstanding not
integrated candidates like this one. 

Would it be possible to spend few minutes by backporting this fix? Thank you in
advance.
Comment 12 Jiri Rechtacek 2002-12-03 13:52:54 UTC
Created attachment 8141 [details]
diff for review
Comment 13 Jiri Rechtacek 2002-12-03 13:53:41 UTC
Davide, please for review the attached file "patch_for_review.diff".
Thanks
Comment 14 David Strupl 2002-12-03 16:24:32 UTC
Reviewed.
Comment 15 Jiri Rechtacek 2002-12-03 16:38:15 UTC
the attached patch applied in release341 branch
Comment 16 _ mihmax 2002-12-06 15:24:02 UTC
Was this commited to release341 branch?
If yes, why no CVS log?

Sincere Max

Comment 17 Jiri Rechtacek 2002-12-07 13:15:42 UTC
  User: jrechtacek
  Date: 02/12/03 08:34:27

  Modified:    src/org/openide/explorer/view Tag: release341
                        DropGlassPane.java TreeViewDragSupport.java
                        TreeViewDropSupport.java
  Log:
  applied the patch from issue #25963: the original glass pane is set
back and set visible as was
  
  Revision  Changes    Path
  No                   revision
Comment 18 _ mihmax 2002-12-08 09:57:11 UTC
Jiri, thanks a lot!
Max
Comment 19 Quality Engineering 2003-07-01 16:17:51 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.