This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 25925 - Cleanup of help support for property editors
Summary: Cleanup of help support for property editors
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Property Editors (show other bugs)
Version: 3.x
Hardware: All All
: P4 blocker (vote)
Assignee: akemr
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-07-23 17:18 UTC by Rochelle Raccah
Modified: 2008-12-22 18:59 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rochelle Raccah 2002-07-23 17:18:44 UTC 
Issue 19294 addresses generic support for property
editors but makes reference to a previous
implementation in DataObject editor which must be
cleaned up.  This is a separate issue filed to
capture the cleanup info in that issue.  Here's
the relevant info:

"This probably makes my fix for issue 12518
redundant.  Has that code been cleaned up?" (me)

"Yes, it could be cleaned - but you probably
should at first change your code from:
propertyDescriptor.setValue(DataObjectEditor.PROPERTY_HELPID,
helpID )
to:
propertyDescriptor.setValue(ExPropertyEditor.PROPERTY_HELP_ID,
helpID )" (Ales)

"But the value in DataObject editor is private and
has the same value as in ExPropertyEditor.  So
(client) code which used to say
propertyDescriptor.setValue( "helpID", helpID )
should be changed to propertyDescriptor.setValue(
ExPropertyEditor.PROPERTY_HELP_ID, helpID ) but it
will still work meanwhile.  I only have an example
of this (not in my real code) anyway.  I think you
can clean it up without breaking anything." (me)

The cleanup is yet to be done.
Comment 1 akemr 2002-07-24 09:52:56 UTC 
Fixed in trunk.

Thanks for reminding Rochelle, I forgot to do it..
Comment 2 Rochelle Raccah 2002-07-24 17:23:34 UTC 
Thanks, Ales.  Please also move the helpID instructions from the
DataObject part to the generic part in the docs:
<http://www.netbeans.org/source/browse/openide/api/doc/org/openide/explorer/doc-files/api.html>
Comment 3 akemr 2002-07-25 08:55:54 UTC 
API documentation was updated.
Comment 4 Rochelle Raccah 2003-07-10 01:34:02 UTC 
Looks good.