This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
When I switch to dark L&F (or Norway Today scheme) then it is impossible to see in "Diff" view changed symbols inside the line, because of used color with very dark bg. Please, change them to make colors visible in Norway Today scheme Thanks, Vladimir.
Created attachment 159230 [details] impossible to distinguish ImEE from IjEE
Tools -> Options -> Fonts & Colors -> Diff tab -> Color of Changed Text. Set it to anything you want. It should help.
Thanks. I know where to change. This is just an issue to make default color better like https://netbeans.org/bugzilla/show_bug.cgi?id=258606 You can use nice resource http://paletton.com/ to find good composition of colors, because you need to find color which is good for dark theme + selected/not_selected current line color should be considered as well
Sure, if you find a good and proper colour I am more than happy to change the default. But I am sorry I do not have time to inspect all possible variations of the background/foreground colours. Or if you know a UX person who could help us, please add him/her on CC.
Ilia, could you, please, suggest good colors for Dark Theme in Diff View. Thanks!
Created attachment 159249 [details] Before
Created attachment 159250 [details] After
I suggest #242F65 as a new color. It's a bit lighter than colors of the removed and added text, but it's only way to make it distinguishable from BG color and Highlighted caret row color. Also the color of the removed text worth to be changed to #381E1E So, Changed text: #202833 -> #242F65 Removed text: #332024 -> #381E1E Also note that "Color of Unapplied Text When Merging" and "Color if Unresolved Conflict" should be changed to corresponding colors too. Vladimir, let me know what you and users think about these colors.
Are you sure that blue background with light-blue text is contrast enough? What about poor-sighted developers? Is it OK?
fix: http://hg.netbeans.org/core-main/rev/b5fa3e7d79ff
Thanks, Ondrej! It seems that the color scheme is not suitable for use by poor-sighted developers. But I'm not sure it should be suitable, because there are a lot of types of сolor blindness and one color scheme can't be right for all. So I took the most applicable color to the existing color scheme, considering that the "changed" is usually associated with a blue color. If we could change color to e.g. purple, things will get better.
Integrated into 'main-silver', will be available in build *201604160001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/b5fa3e7d79ff User: Ondrej Vrabec <ovrabec@netbeans.org> Log: #258789 - [dark] modified symbols in diff are invisible Change diff colors according to the cnd request