I am not sure but I think that these lines are written by Xdebug itself and not
NetBeans. But I am not sure, I need to verify it first. Feel free to do it, if
you would like to help us :)

Thanks for reporting.

Created attachment 158273 [details]
toLowerCase Locale Correction

@Tomas I added a patch file to resolve this issue. This solution should apply to all of the enum types like that pattern.

(In reply to threedot from comment #3)
> @Tomas I added a patch file to resolve this issue. This solution should
> apply to all of the enum types like that pattern.

Perfect! Thanks a lot for your time and your patch! I will apply it soon.

Thanks.

Patch applied, feel free to verify it (wait for a message that will appear here automatically saying in which dev build of NetBeans this change will be present).

Thanks.

http://hg.netbeans.org/web-main/rev/00a16c36d179

(In reply to Tomas Mysik from comment #5)
> Patch applied, feel free to verify it (wait for a message that will appear
> here automatically saying in which dev build of NetBeans this change will be
> present).
> 
> Thanks.
> 
> http://hg.netbeans.org/web-main/rev/00a16c36d179

Thank you. It looks like OK but if there are some convention in other classes like "public enum Type" and "toString().toLowerCase()" should replace like this solution. 

I can't discover because project cloning is too hard using mercurial is too slow. I waited to clone for minutes and I couldn't have it.


Finally i fetched single file (BrkpntSetCommand.java) from repo and edit it manually.

Integrated into 'main-silver', will be available in build *201601300002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/00a16c36d179
User: Tomas Mysik <tmysik@netbeans.org>
Log: #257499 - breakpoint_set Problem for Turkish Locale

Patch contributed by threedot@netbeans.org.

There is no other LINE constant in any other enum so your use case may be fixed. If you confirm it, I will change all the toLowerCase() calls.

Thanks.

Created attachment 158354 [details]
toLowerCase locale correction 2

(In reply to Tomas Mysik from comment #8)
> There is no other LINE constant in any other enum so your use case may be
> fixed. If you confirm it, I will change all the toLowerCase() calls.
> 
> Thanks.

I downloaded shallow copy of the project and i changed for other places and i attached the patch

(In reply to Quality Engineering from comment #7)
> Integrated into 'main-silver', will be available in build *201601300002* on
> http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
> 
> Changeset: http://hg.netbeans.org/main-silver/rev/00a16c36d179
> User: Tomas Mysik <tmysik@netbeans.org>
> Log: #257499 - breakpoint_set Problem for Turkish Locale
> 
> Patch contributed by threedot@netbeans.org.

Have you tried this build please? Is the issue still present?

Thanks.

I was tested the patch with Netbeans 201603070002. Here is the results:

Log opened at 2016-03-07 22:05:16
I: Connecting to configured address/port: 127.0.0.1:9000.
I: Connected to client. :-)
-> <init xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" fileuri="file:///D:/inetpub/wwwroot/sedd/index.php" language="PHP" xdebug:language_version="5.6.1-dev" protocol_version="1.0" appid="9780" idekey="netbeans-xdebug"><engine version="2.4.0"><![CDATA[Xdebug]]></engine><author><![CDATA[Derick Rethans]]></author><url><![CDATA[http://xdebug.org]]></url><copyright><![CDATA[Copyright (c) 2002-2016 by Derick Rethans]]></copyright></init>

<- feature_set -i 7 -n show_hıdden -v 1
-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="feature_set" transaction_id="7" status="starting" reason="ok"><error code="3"><message><![CDATA[invalid or missing options]]></message></error></response>

<- feature_set -i 8 -n max_depth -v 3
-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="feature_set" transaction_id="8" feature="max_depth" success="1"></response>

<- feature_set -i 9 -n max_chıldren -v 30
-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="feature_set" transaction_id="9" status="starting" reason="ok"><error code="3"><message><![CDATA[invalid or missing options]]></message></error></response>

<- feature_set -i 10 -n max_data -v 2048
-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="feature_set" transaction_id="10" feature="max_data" success="1"></response>

<- breakpoint_set -i 11 -t line -s enabled -f file:///D:/inetpub/wwwroot/hotspot/local/www/sedd/modules/Hesap_Yonetimi/Hesaplar/Hesaplar.php -n 177
-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="breakpoint_set" transaction_id="11" state="enabled" id="97800001"></response>

<- run -i 12
-> <response xmlns="urn:debugger_protocol_v1" xmlns:xdebug="http://xdebug.org/dbgp/xdebug" command="run" transaction_id="12" status="stopping" reason="ok"></response>

breakpoint_set command has valid characters, but "show_hidden" and "max_children" attribute names is invalid, they has "ı" chars instead of "i" like "breakpoint_set" old "line" command befaore this patch.

i think debugger protocol commands, attributes or names (reserved words like feature_set, line, max_children) must be constant and should not be convert upper or lower case depending system locale.

the patch must be in php.dbgp/src/org/netbeans/modules/php/dbgp/packets/FeatureGetCommand.java:

public String toString()
    {
      return super.toString().toLowerCase();
    }

to

public String toString()
    {
      return super.toString().toLowerCase(Locale.US);
    }

or

change static enum strings to lowercase (statically) in all classes in dbgp module and do not convert to lowercase at runtime

Will change all enums. Thanks guys for your cooperation and help!

Should be fixed now I hope. Please verify if possible, thanks.

http://hg.netbeans.org/web-main/rev/ab17d1583434