This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
See https://netbeans.org/bugzilla/show_bug.cgi?id=256791 << Fixing in releases: 304996 6e1b00e69e6b | petrk | 2015-12-09 17:22 +0300 | Fixing #256791 - failing SelectModelTestCase.testSelectModelGetFunctions on Ubuntu test machine 305073 67b8a35ad5ac | petrk | 2015-12-15 00:55 +0300 | Fixing #256791 - failing SelectModelTestCase.testSelectModelGetFunctions on Ubuntu test machine This bug is partially fixed. I mark this one as fixed and open a new one. >>
No test case to reproduce the original bug. Hope that NPE was fixed.
Sorry, ignore previous comment.
Integrated into 'main-silver', will be available in build *201512220002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/aa98a7b66f14 User: Petr Kudryavtsev <petrk@netbeans.org> Log: Fixing #257152 - was [Bug 256791 - failing SelectModelTestCase.testSelectModelGetFunctions on Ubuntu test machine] (transplanted from 981e71e3b94fe8df437ba1c168d4c5e9397dc718)
Fixes of this bug: http://hg.netbeans.org/releases/rev/981e71e3b94f http://hg.netbeans.org/releases/rev/e64ba4618b3e
Integrated into 'main-silver', will be available in build *201601280002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/f0eb0bdd5d93 User: Petr Kudryavtsev <petrk@netbeans.org> Log: Fixed #257152 - was [Bug 256791 - failing SelectModelTestCase.testSelectModelGetFunctions on Ubuntu test machine] -- improved parser recovery (transplanted from d8bc693d534dfab3b9fbb2eb5f030966518633be)
Integrated into 'main-silver', will be available in build *201601290002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/8cdd1008a08e User: Petr Kudryavtsev <petrk@netbeans.org> Log: Additional fix for #257152 - was [Bug 256791 - failing SelectModelTestCase.testSelectModelGetFunctions on Ubuntu test machine] -- added simple recovery for C (transplanted from 437517a2ae8804b2f2eb3a2a243c1120331f0caf)
Created attachment 158293 [details] Final patch
We need to integrate this into 8.1 after all tests pass on our private build/test servers
at enum 305926:1f9a0f817162 [release81]
Minimal test case with zero declarations: ===========8<=============== __BEGIN_NAMESPACE_STD extern FILE *tmpfile (void) __wur; ===========8<=============== when __BEGIN_NAMESPACE_STD is absent then tmpfile is declared
extra fix 305938:84dfd62eded4 [release81]
v.
Fixes of this bug: http://hg.netbeans.org/releases/rev/1f9a0f817162 http://hg.netbeans.org/releases/rev/84dfd62eded4
Integrated into 'main-silver', will be available in build *201602050002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/74ee6ad1ca39 User: Vladimir Voskresensky <vv159170@netbeans.org> Log: fixed #257152 - was [Bug 256791 - failing SelectModelTestCase.testSelectModelGetFunctions on Ubuntu test machine] (with PetrK) - recovery for C and C++ languages which doesn't break K&R support in C++ files (transplanted from 1f9a0f817162b9f9de54decbf755f9a57cc1c1c6)
It seems the fix is not safe. I got an infinite parsing with stack: at org.netbeans.modules.cnd.modelimpl.parser.generated.CPPParser.function_K_R_parameter_g(CPPParser.java:45431) at org.netbeans.modules.cnd.modelimpl.parser.generated.CPPParser.function_K_R_parameter_list_g(CPPParser.java:39010) at org.netbeans.modules.cnd.modelimpl.parser.generated.CPPParser.unknown_postfunction_declarator_specifiers_g(CPPParser.java:51557) at org.netbeans.modules.cnd.modelimpl.parser.generated.CPPParser.function_like_var_declarator_g(CPPParser.java:42650) at org.netbeans.modules.cnd.modelimpl.parser.generated.CPPParser.direct_declarator_g(CPPParser.java:47949) at org.netbeans.modules.cnd.modelimpl.parser.generated.CPPParser.declarator_g(CPPParser.java:40517) at org.netbeans.modules.cnd.modelimpl.parser.generated.CPPParser.init_declarator_g(CPPParser.java:48974) at org.netbeans.modules.cnd.modelimpl.parser.generated.CPPParser.init_declarator_list_g(CPPParser.java:40753) at org.netbeans.modules.cnd.modelimpl.parser.generated.CPPParser.declaration_g(CPPParser.java:39356) at org.netbeans.modules.cnd.modelimpl.parser.generated.CPPParser.function_K_R_parameter_g(CPPParser.java:45431) at org.netbeans.modules.cnd.modelimpl.parser.generated.CPPParser.function_K_R_parameter_list_g(CPPParser.java:39010)
I'd prefer to rollback all changes in grammar. It do not looks a safe.Especially: 1.7 unknown_postfunction_declarator_specifiers 1.8 {String s
(In reply to Alexander Simon from comment #16) > I'd prefer to rollback all changes in grammar. It do not looks a > safe.Especially: 1.7 unknown_postfunction_declarator_specifiers 1.8 > {String s I mean change set: http://hg.netbeans.org/main-silver/rev/f0eb0bdd5d93 that introduced greedy function unknown_postfunction_declarator_specifiers
Created attachment 158386 [details] Thread dump after about 1 hour of parsing
I agree to rollback all changes in grammar made for this issue
at enum: 305999:d94593afaea8 [release81]
Vladimir, https://hg.netbeans.org/releases/log/d94593afaea8 does not exist. Can you please explain what you meant by your last comment?
It is "at enum" - our build server where we are running all tests, when they are passed, change will propagate into releases. That's why I've removed 81patch1-fixed as well
Do not see parsing problem any more. Checked build from enum.
pushed to release http://hg.netbeans.org/releases/rev/d94593afaea8
Integrated into 'main-silver', will be available in build *201602060002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/e20c7343289f User: Vladimir Voskresensky <vv159170@netbeans.org> Log: fixed #257152 - was [Bug 256791 - failing SelectModelTestCase.testSelectModelGetFunctions on Ubuntu test machine] - rollback changes in grammar and mark tests as @Ignore (transplanted from d94593afaea86b2adde8446d512915321979e1a1)
Integrated into 'main-silver', will be available in build *201603040002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/34efd66cc693 User: Vladimir Voskresensky <vv159170@netbeans.org> Log: extra fix for #257152 - was [Bug 256791 - failing SelectModelTestCase.testSelectModelGetFunctions on Ubuntu test machine] (with PetrK) - don't use system specific include paths (it makes tests unstable on some test machines)