This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Write jdkhome into runide.sh or another appropriate place. Users without java in PATH and without JDK_HOME env. properties will be able to run IDE without setting this properties after install.
Changed WriteAction bean writes info about jdkhome used for launching installer into ide.cfg. That means user with no JDK_HOME set will be able to run IDE. There were changed jvm files used for search. j2sdk1.4.1 support is included. Fixed in trunk.
Created attachment 6681 [details] diff of the change in trunk
I don't like the writeJDKHome() method impl. It hardcodes the default contents of ide.cfg which we might like to change by editing core/release/bin/ide.cfg. Please change this method to: 1. Read the existing ide.cfg. If there is any line matching "-jdkhome", do nothing. 2. If there is no such line, append "-jdkhome ${jdkhome}\n" to the file, using the append mode in FileWriter, so as to retain any existing settings in the config file. Line breaks in the config file ought to be ignored (please test of course). By the way, I see many lines in the attached diff which are purely changes of whitespace (deleting trailing spaces). These meaningless changes make the diff much harder for a reviewer to read. For more, see the recommendations here: http://www.netbeans.org/devhome/docs/code_conventions.html
Good idea. I rewrote WriteAction.
Created attachment 6688 [details] diff of the change in trunk
Looks better, thanks. BTW at least in the trunk version please make sure to close FileReader fr in a finally-block, for safety. (Probably better to not have the FileWriter open on the same file when the FileReader is open, too: open & close the FR first, then maybe open & close the FW.)
Created attachment 6707 [details] diff of changes proposed by Jesse. Is it O.K. Jesse?
Looks good to me.
Created attachment 6756 [details] diff of changes in NB.xml
Created attachment 6757 [details] diff of changes in NB.xml - previous one caused problem with build
Below are attached files which should be on branch 34 for correct functionality of this fix. Those are jvm files containing definition of search. They are not on branch 34.
Created attachment 6787 [details] jvm file for ibm 1.4.1 jdk (future use)
Created attachment 6789 [details] jvm for sun jdk1.3.1
Created attachment 6790 [details] jvm for sun jdk141
Probably better will be to put only links to other files. So here are: http://installer.netbeans.org/source/browse/installer/jvms/solaris/sun.jdk.1.3.1.solaris.jvm?rev=1.2&content-type=text/x-cvsweb-markup http://installer.netbeans.org/source/browse/installer/jvms/solaris/sun.jdk.1.4.1.solaris.jvm?rev=1.2&content-type=text/x-cvsweb-markup http://installer.netbeans.org/source/browse/installer/jvms/solaris/sun.jdk.1.4.solaris.jvm?rev=1.2&content-type=text/x-cvsweb-markup http://installer.netbeans.org/source/browse/installer/jvms/win32/sun_win32_13X.jvm?rev=1.1&content-type=text/x-cvsweb-markup http://installer.netbeans.org/source/browse/installer/jvms/win32/sun_win32_141.jvm?rev=1.1&content-type=text/x-cvsweb-markup
Reviewed. The patch looks correct.
Fixed in release34.
verified.