This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 253748 - Version Diff View seems to be broken
Summary: Version Diff View seems to be broken
Status: VERIFIED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Diff (show other bugs)
Version: 8.1
Hardware: PC Windows 7
: P2 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords:
Depends on: 248900
Blocks:
  Show dependency tree
 
Reported: 2015-07-24 15:01 UTC by Maksim Khramov
Modified: 2015-07-31 12:44 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maksim Khramov 2015-07-24 15:01:07 UTC
Product Version: NetBeans IDE Dev (Build 201507200001)
Java: 1.8.0_51; Java HotSpot(TM) 64-Bit Server VM 25.51-b02
Runtime: Java(TM) SE Runtime Environment 1.8.0_51-b13

Steps to reproduce:
I have JSP file under Mercurial source control with 1 line added.
Open Diff to Base view on this file.
The added line is marked with green background highlight and have remove button (x)
Click on this button.
The added line is disappears but selection highlight and remove button are not, so I can continue to remove lines even them is unchanged.
Comment 1 Ondrej Vrabec 2015-07-25 18:13:50 UTC
regression caused by fix for #248900
Comment 2 Ondrej Vrabec 2015-07-25 18:32:52 UTC
fix: http://hg.netbeans.org/core-main/rev/98289aa83933
Comment 3 Ondrej Vrabec 2015-07-27 07:40:22 UTC
Jirko, this is a beta stopper, could you please verify the fix?
Comment 4 Ondrej Vrabec 2015-07-27 12:02:57 UTC
Vlado, this is a beta stopper, could you please verify the fix?
Comment 5 Vladimir Riha 2015-07-27 12:13:47 UTC
Sure
Comment 6 Vladimir Riha 2015-07-28 11:18:40 UTC
Verified in custom build, please transplant to beta branch. Thank you

Product Version: NetBeans IDE Dev (Build Trunk-Build-1303-on-20150728)
Java: 1.8.0_45; Java HotSpot(TM) 64-Bit Server VM 25.45-b02
Runtime: Java(TM) SE Runtime Environment 1.8.0_45-b14
System: Linux version 3.16.0-30-generic running on amd64; UTF-8; en_US (nb)
Comment 7 Ondrej Vrabec 2015-07-28 12:56:38 UTC
beta fix: #5811e64b64b2
Comment 8 Quality Engineering 2015-07-29 01:28:56 UTC
Integrated into 'main-silver', will be available in build *201507290002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/98289aa83933
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: #253748 - Version Diff View seems to be broken
Comment 9 Vladimir Riha 2015-07-31 12:44:17 UTC
Verified in Beta, thank you

Product Version: NetBeans IDE 8.1 Beta (Build 201507302201)
Java: 1.8.0_51; Java HotSpot(TM) 64-Bit Server VM 25.51-b03
Runtime: Java(TM) SE Runtime Environment 1.8.0_51-b16
System: Linux version 3.16.0-30-generic running on amd64; UTF-8; en_US (nb)