This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 253648 - Two warning dialogs shown when changing a variable/watch to an invalid value
Summary: Two warning dialogs shown when changing a variable/watch to an invalid value
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Property Sheet (show other bugs)
Version: 8.1
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-22 11:28 UTC by Jan Stola
Modified: 2015-09-02 05:16 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Stola 2015-07-22 11:28:14 UTC 
Test case:

public class TwoDialogs {
    
    public static void main(String[] args) {
        int value = 1;
        System.out.println(value);
    }
    
}


Steps to reproduce:
1. Put a breakpoint on the System.out.println() statement in the test-case above.
2. Debug the file and wait till it hits the breakpoint.
3. Attempt to change the value of the "value" variable to "test".
   => a warning dialog is shown.
4. Move this dialog aside. You will see that there is another copy of this dialog.
Comment 1 Martin Entlicher 2015-07-29 07:44:20 UTC 
Reproduced.
Comment 2 Martin Entlicher 2015-09-01 09:57:58 UTC 
The setValueAt() is called two times:

1)
org.netbeans.modules.viewmodel.TreeModelNode$MyProperty.setValue(TreeModelNode.java:2147)
org.openide.explorer.propertysheet.NodePropertyModel.setValue(NodePropertyModel.java:113)
org.openide.explorer.propertysheet.PropUtils.noDlgUpdateProp(PropUtils.java:562)
org.openide.explorer.propertysheet.EditablePropertyDisplayer._commit(EditablePropertyDisplayer.java:211)
org.openide.explorer.propertysheet.EditablePropertyDisplayer.commit(EditablePropertyDisplayer.java:132)
org.openide.explorer.propertysheet.EditablePropertyDisplayer$InplaceEditorListener.actionPerformed(EditablePropertyDisplayer.java:823)
javax.swing.JTextField.fireActionPerformed(JTextField.java:508)
...

2)
org.netbeans.modules.viewmodel.TreeModelNode$MyProperty.setValue(TreeModelNode.java:2147)
org.openide.explorer.propertysheet.NodePropertyModel.setValue(NodePropertyModel.java:113)
org.openide.explorer.propertysheet.PropUtils.noDlgUpdateProp(PropUtils.java:562)
org.openide.explorer.propertysheet.EditablePropertyDisplayer._commit(EditablePropertyDisplayer.java:211)
org.openide.explorer.propertysheet.EditablePropertyDisplayer.commit(EditablePropertyDisplayer.java:132)
org.openide.explorer.propertysheet.PropertyPanel.commit(PropertyPanel.java:462)
org.openide.explorer.propertysheet.PropertyPanel.access$400(PropertyPanel.java:122)
org.openide.explorer.propertysheet.PropertyPanel$BridgeAccessor.commit(PropertyPanel.java:1310)
org.netbeans.modules.openide.explorer.PropertyPanelBridge.commit(PropertyPanelBridge.java:74)
org.openide.explorer.view.SheetCell$OutlineSheetCell.stopCellEditing(SheetCell.java:792)
org.openide.explorer.propertysheet.PropertyPanel$Listener.actionPerformed(PropertyPanel.java:1292)
org.openide.explorer.propertysheet.EditablePropertyDisplayer.fireActionPerformed(EditablePropertyDisplayer.java:701)
org.openide.explorer.propertysheet.EditablePropertyDisplayer.access$400(EditablePropertyDisplayer.java:92)
org.openide.explorer.propertysheet.EditablePropertyDisplayer$InplaceEditorListener.actionPerformed(EditablePropertyDisplayer.java:829)
javax.swing.JTextField.fireActionPerformed(JTextField.java:508)
...
Comment 3 Martin Entlicher 2015-09-01 16:18:48 UTC 
Fixed by changeset:   291342:a09300ca7fbe
http://hg.netbeans.org/core-main/rev/a09300ca7fbe
Comment 4 Quality Engineering 2015-09-02 05:16:36 UTC 
Integrated into 'main-silver', will be available in build *201509020320* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/a09300ca7fbe
User: mentlicher@netbeans.org
Log: #253648: Prevent from two commit calls on inplace editor action.