This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Development build #200206260100 of NetBeans 3.4 Windows 2000 with JDK 1.4.1 RC build #15 Description: ============ This is quite interesting bug. Users can't create basic variables to CVS or PVCS filesystems or at least they are not visible in the customizer. The most strange is that it seems like VSS was not affected. Looks like regression ? Steps to reproduce: =================== 1. Invoke "Versioning|Mount Version Control|Generic VCS". 2. Select CVS profile and push "Next >" button. 3. Click "Edit Variables..." and right click "Basic" node. 4. Choose "Add Variable", type "Name" and click "OK". 5. Push "Finish" and invoke the customizer after the filesystem is mounted into explorer. 6. There is no "Name:" textfield in it.
This is because CONFIG_INPUT_DESCRIPTOR variable is defined. This variable defines a descriptor of input components, that are located in Profile panel. If this is defined, basic variables have no meaning then. This should be solved as a UI problem. The functionality is O.K., but from the UI it's not apparent, that the basic variables do not play the former role.
Filip, do you have any idea how can we fix this? It's necessary to let the user know, that the Basic variables have no effect to the Profile tab when CONFIG_INPUT_DESCRIPTOR variable is defined. But the variables can still be used by commands. One solution, that just came to my mind: - if the user defines CONFIG_INPUT_DESCRIPTOR variable (or if it's already defined in the XML profile), remove all variables from the "Basic" folder and put them all into "Accessory" folder. This will indicate, that they have no special meaning now. The "Basic" folder can be disabled then, so that the user can not create additional "basic" variable, but only accessory one. The "Basic" folder can also get a tooltip describing the reason why it is disabled. - I will still remember, which variables are "basic" and therefore if the user remove the CONFIG_INPUT_DESCRIPTOR variable, we'll enable the "Basic" folder again and move all basic variables there. Comments/suggestions?
I agree with this suggestion. Since the implications of this bug would be confusing for users, it must be fixed and the easiest solution seems to be the one Martin wrote. So, let's do this (if CONFIG_INPUT_DESCRIPTOR variable is defined): 1) Move all Basic variables to Accessory node. 2) Disable Basic node and put a tooltip describing this situation on it. And, of course, mention this case in documentation.
Thanks Filip for your comments. I've started to implement it, but as I know there's no easy way how to make the node "disabled". So if it's O.K., to get the "disabled" state, I'll replace the node's icon with gray icon, make the text gray and remove all actions and change the tooltip. I'm not sure yet whether I'll be able to make the tooltip gray as well.
I think that making the node non-expandable with grey icon and text would be sufficient. The tooltip can stay "normal", there is no need to make it grey as well.
Fixed as proposed in dev build Jun 29.
Sorry, but it's not perfect yet. If CONFIG_INPUT_DESCRIPTOR variable is empty, Basic becomes editable and takes over all necessary variables, however proper settings are not visible on Profile tab of the wizard. Trying to verify in development build #200208050100 of NetBeans 4.0. Steps to reproduce: =================== 1. Invoke "Versioning|Mount Version Control|Generic VCS". 2. Select CVS profile and push "Next >" button. 3. Click "Edit Variables..." and expand "Accessory" node. 4. Delete value of CONFIG_INPUT_DESCRIPTOR variable. 5. Push "OK" and "< Back" buttons. No setting is visible.
Starting to work on a fix...
Fixed in the main trunk. Diff: http://vcsgeneric.netbeans.org/source/browse/vcsgeneric/src/org/netbeans/modules/vcs/advanced/VcsCustomizer.java.diff?r1=1.89&r2=1.90
Verified in development build #200211070100 of NetBeans 4.0.
Hi. This issue is marked as 3.4.1_CANDIDATE. It means that it should be integrated into release341 one branch. The plan at http://www.netbeans.org/devhome/docs/releases/34/index.html expected beta1 to be produced on Dec01. That did not happen due to a lot of outstanding not integrated candidates like this one. Would it be possible to spend few minutes by backporting this fix? Thank you in advance.
Merged into release341 branch. /cvs/vcsgeneric/src/org/netbeans/modules/vcs/advanced/VcsCustomizer.java,v <-- VcsCustomizer.java new revision: 1.87.6.1.4.1; previous revision: 1.87.6.1
Resolved for 3.4.x or earlier, no new info since then -> closing.