This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 248315 - Unneeded registration Ctrl+Z and Ctrl+Y
Summary: Unneeded registration Ctrl+Z and Ctrl+Y
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Actions/Menu/Toolbar (show other bugs)
Version: 8.0.1
Hardware: PC Solaris
: P3 normal (vote)
Assignee: Miloslav Metelka
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2014-10-31 13:43 UTC by Alexander Simon
Modified: 2014-11-14 03:56 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
profiling snapshot (341.67 KB, application/octet-stream)
2014-11-05 09:27 UTC, Alexander Simon
Details
proposed patch (1.04 KB, patch)
2014-11-10 12:16 UTC, Alexander Simon
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Simon 2014-10-31 13:43:37 UTC
The method
org.netbeans.editor.BaseAction.actionPerformed(final ActionEvent evt)
register in uigestures Ctrl+Z and Ctrl+Y keys.
It is a performance issue.
Each key typing results in writing on disk about 2K unneeded info.
Fast typing person see a slowness in editor.

Compare behavior of undo/redo which is not registered.

Please filter out registration.
Comment 1 Alexander Simon 2014-10-31 13:48:32 UTC
For example from snapshot:
org.netbeans.editor.BaseAction.actionPerformed()	19.818438	35,218 ms (19.8%)	20,125 ms
  java.util.logging.Logger.log()	8.443336	15,004 ms (8.4%)	24.6 ms
Comment 2 Miloslav Metelka 2014-11-03 09:34:16 UTC
Please attach the performance snapshot. Thanks.
Comment 3 Alexander Simon 2014-11-05 09:27:43 UTC
Created attachment 150286 [details]
profiling snapshot
Comment 4 Alexander Simon 2014-11-10 12:16:36 UTC
Created attachment 150391 [details]
proposed patch
Comment 6 Quality Engineering 2014-11-10 23:21:12 UTC
Integrated into 'releases/release801', will be available in build *201411102027* or newer. Wait for official and publicly available build.

Changeset: http://hg.netbeans.org/releases/rev/09c1b6f26d34
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixed Bug #248315 Unneeded registration Ctrl+Z and Ctrl+Y
(transplanted from 720a3f7c48d488cee7a1b2e80d0c8e5471275583)
Comment 7 Quality Engineering 2014-11-11 03:52:24 UTC
Integrated into 'main-silver', will be available in build *201411110002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/720a3f7c48d4
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixed Bug #248315 Unneeded registration Ctrl+Z and Ctrl+Y
Comment 8 Quality Engineering 2014-11-12 03:57:32 UTC
Integrated into 'main-silver', will be available in build *201411120002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/720a3f7c48d4
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixed Bug #248315 Unneeded registration Ctrl+Z and Ctrl+Y
Comment 9 Quality Engineering 2014-11-13 03:48:49 UTC
Integrated into 'main-silver', will be available in build *201411130002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/720a3f7c48d4
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixed Bug #248315 Unneeded registration Ctrl+Z and Ctrl+Y
Comment 10 Quality Engineering 2014-11-14 03:56:05 UTC
Integrated into 'main-silver', will be available in build *201411140002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/720a3f7c48d4
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixed Bug #248315 Unneeded registration Ctrl+Z and Ctrl+Y