This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 246777 - Get rid of static 'seen' variable in Unbalanced hint
Summary: Get rid of static 'seen' variable in Unbalanced hint
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Hints (show other bugs)
Version: 8.0
Hardware: All All
: P3 normal (vote)
Assignee: Svata Dedic
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-29 13:45 UTC by Tomas Hurka
Modified: 2015-07-29 01:30 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Hurka 2014-08-29 13:45:08 UTC 
It would be better to rewrite org.netbeans.modules.java.hints.bugs.Unbalanced hint in such a way that it will not need static WeakHashMap seen variable. Current implementation crates memory leak, when Compilation instance is also indirectly held by value of seen's WeakHashMapEntry. See issue #246717 for one example of such memory leak indirectly caused by Unbalanced hint.
Comment 1 Tomas Hurka 2014-08-29 14:02:47 UTC 
See issue #246778 for another example.
Comment 2 Svata Dedic 2015-07-27 12:55:24 UTC 
cache moved to compilation info, invalidates after source change - jet-main#54216150aa68
Comment 3 Quality Engineering 2015-07-29 01:30:23 UTC 
Integrated into 'main-silver', will be available in build *201507290002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/54216150aa68
User: Svata Dedic <sdedic@netbeans.org>
Log: #246777: identifier usage collected in the CompilationInfo to avoid leaks