This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 246523 - Apache TomEE 1.7.0 Not Properly Detected
Summary: Apache TomEE 1.7.0 Not Properly Detected
Status: NEW
Alias: None
Product: serverplugins
Classification: Unclassified
Component: TomEE (show other bugs)
Version: 8.0
Hardware: PC Linux
: P3 normal with 1 vote (vote)
Assignee: issues@serverplugins
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-18 17:37 UTC by kwrobel
Modified: 2014-08-18 17:37 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kwrobel 2014-08-18 17:37:40 UTC
Apache TomEE 1.7.0 was recently released and NetBeans 8.0 Patch 2 fails to detect it properly, similar to bug# 237453 but different.

I have debugged the Tomcat5 plugin and found the spot where detection fails.

1. TomcatManager.java has an enumeration called TomEEVersion which lists TOMEE_15 and TOMEE_16. It should be expanded to TOMEE_17.
2. TomcatFactory.java has a method called getTomEEVersion() which tests only for versions starting with literals "1.5." and "1.6.". This should be expanded with another test for "1.7." and assigning the TomEEVersion enumeration mentioned above.

I have made these modifications in my local NetBeans source tree and it works as expected with those lines modified, e.g. when I add Entities from Database, I get the prompt to create a new Data Source instead of using a JDBC Database Connection, and I can also use the JSF Pages from Entities wizard without getting an error message.

Imo though, this is not a good way to test whether manager.isTomEE because all these hard-coded version string will bite NetBeans back as soon as TomEE goes to yet another version. Maybe they will jump to TomEE 1.8 or 2.0 or whatever will come next, and NetBeans will again fail detection. I don't have any suggestion for the future, but this is not going to work well since TomEE is a project that will see more releases in the future.

In any case, if the steps above are implemented soon, this will at least help those with Apache TomEE 1.7 installed. Plus the changes that were already fixed in the other bug report.

Please advise.