Created attachment 147804 [details]
ScreenShot

The NetBeans highlights the matched parts of the name by bold fond in Go To File, Go To Type, Go To Symbol. See the attached screenshot.

Nice, but if you see my screenshot, it's not there, I stick my eyes to my monitor and can't see it. Windows 7 (x64). I will try it at an other place but I think it isn't there too as I remember.

Sry, please see my new screenshot (No selection)

Created attachment 147805 [details]
No selection

I can't see any bolder text. Maybe it's because of my monitors, but I don't know.

It may be a font problem. The OS/JVM has not bolt version of given font.
It's Windows 7 which JDK?
Thanks

Java 7 Update 60 and Java SE Development Kit 7 Update 60.

I will try to get some Windows 7 machine and try to reproduce it.
Thanks for info!

Should we reopened the ticket?

Yes, please reopen it.

Reopened as discussed.

jet-main 2567aaa2e009

Hi Chris.
The color highlighting is now implemented just for Go To Type and Go To Symbol.
I will add Go To File later.

The NB highlights matches by bold by default, but as you pointed out it may be problem on some systems. The jumpto uses NB specific HtmlRenderer to render the name with bold. It's faster compared to JLabel. Unfortunately it cannot paint background. So I needed to use JLabel for background rendering. As far as I remember there were some problems regarding using JLabel in jumpto, but I don't remeber them. On Mac the JLabel looks fine (see attached screenshot), unfortunately I have no other OS to try.

So I enabled the color highlighting just on command line option jumpto.highlight=color. Can you test it if it's OK on Windows? You need to start NB with -J-Djumpto.highlight=color option.

Thanks Tomas

Created attachment 153433 [details]
Screen shot

If it will be OK on all supported systems I will turn it on by default.

Duplicate of https://netbeans.org/bugzilla/show_bug.cgi?id=223657 ?

*** Bug 223657 has been marked as a duplicate of this bug. ***

Yes, it's duplicate.

(In reply to Tomas Zezula from comment #14)
> Unfortunately it cannot paint background. So I needed to use JLabel for background rendering.

I used background-rendering in the past, but I am not sure, if a JLabel is used for rendering.

Screenshot: https://netbeans.org/bugzilla/attachment.cgi?id=123071
Code: https://netbeans.org/bugzilla/attachment.cgi?id=123070&action=diff
Original issue: https://netbeans.org/bugzilla/show_bug.cgi?id=216833

Yes, it was JLabel, I've added the HtmlRenderer because there was some problem.
Unfortunately I don't remember the problem anymore :-)

Go to file part: jet-main b58e70d18f39

Commits:
http://hg.netbeans.org/jet-main/rev/2567aaa2e009
http://hg.netbeans.org/jet-main/rev/b58e70d18f39
http://hg.netbeans.org/jet-main/rev/3a00eca44eeb

Nice, really thx for thix little enhancement :). I would really like to test it, I have to download the latest dev build to test it, I only have the stable 8.0.2 version. I will check it at the weekend or so. Thx :). I will give feedback soon.


Cheers

Chris

Integrated into 'main-silver', will be available in build *201504300001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/2567aaa2e009
User: Tomas Zezula <tzezula@netbeans.org>
Log: #245291:Please add Text selection for the result in the Go to File/Type/Symbol and so on dialog

(In reply to Quality Engineering from comment #25)
> Integrated into 'main-silver', will be available in build *201504300001* on
> http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
> 
> Changeset: http://hg.netbeans.org/main-silver/rev/2567aaa2e009
> User: Tomas Zezula <tzezula@netbeans.org>
> Log: #245291:Please add Text selection for the result in the Go to
> File/Type/Symbol and so on dialog

It works using Windows 7. But it is correct that only the selected line shows the matching characters? Looks strange to me.

Hi Benno,
Thanks for trying on Windows.

Yes, it's intentional when all the items were marked it was very colorful, so I am marking just the selected item. I can add an cmd line option to mark all items, so you can see.

I will do it later today and let you know

Added the option for highlighting all items jet-main 7a3a8fa3c112.
If you run the IDE with -J-Djumpto.highlight=color -J-Djumpto.highlight.all=true all items will be highlighted.
But I think that highlighting just the selected item is nicer.

(In reply to Tomas Zezula from comment #28)
> Added the option for highlighting all items jet-main 7a3a8fa3c112.
> If you run the IDE with -J-Djumpto.highlight=color
> -J-Djumpto.highlight.all=true all items will be highlighted.
> But I think that highlighting just the selected item is nicer.

Idea, Eclipse, Sublime also highlight all items. So i guess that behaviour is expected IMHO. I will wait for a dev build, which integrates your changes, so that I can try it out.

1) Idea highlight just selected (active) item - see idea_screenshot.png

2) Eclipse highlights all items but by bold font as NB. This has the same problem as in NB it's not visible. In eclipse specially the highlighting of active item is not visible at all, see eclipse_screenshot.png

3) Sublime the same as eclipse - bold font used for highlighting, not much visible, see sublime_screenshot.png

4) Brackets the same as Eclipse.

In general the IDEs (editors) either highlight by colour with just active line highlighting or by the bold font with all highlighting. This is also the way how it's implemented in the NB the HighlightingStrategy.isHighlightAll() is true for Bold and false for Color.

Created attachment 153577 [details]
Brackets

Created attachment 153578 [details]
Eclipse

Created attachment 153579 [details]
Idea

Created attachment 153580 [details]
Sublime

Created attachment 153584 [details]
Shows highlighting of all lines in CC

(In reply to Tomas Zezula from comment #30)
> In general the IDEs (editors) either highlight by colour with just active
> line highlighting or by the bold font with all highlighting. 

I am sorry Tomas. You are correct, I checked it. 

I mixed it up with the highlighting in the code completion. There also the non-active lines got highlighted. See the attached screenshot. But this is not part of this issue.

Hi Benno,
no problem.

We should just decide what we enable in release.
Ideally there should be a UI option to switch from Bold to Colour highlighting as Sublime users may prefer Bold while the others may prefer the Colour. For me the colour is much more visible.
However I am unsure if it deserves a panel in IDE Options/Editor

Integrated into 'main-silver', will be available in build *201505120001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/7a3a8fa3c112
User: Tomas Zezula <tzezula@netbeans.org>
Log: #245291:Please add Text selection for the result in the Go to File/Type/Symbol and so on dialog.

Hi Benno,
any update on this?
I think that the best solution will be to add an panel into the IDE's options allowing the user to switch Colour or Bold and All items vs Single Items.

(In reply to Tomas Zezula from comment #38)
> Hi Benno,
> any update on this?
> I think that the best solution will be to add an panel into the IDE's
> options allowing the user to switch Colour or Bold and All items vs Single
> Items.

I thought your last question was a rhetorical one....

An option would be good, but what will be the default. IMHO Most users will neverchange this setting, so the reception of NB UI will be based on the default configuration. 

What do you think? Should we ask/survey the nbdt or platform_dev?

Didn't tried it yet but in my perspective, an option would be very cool to toggle bold/character background selection and first match/all matches. Default should be character background selection and first match. Only my opinion :)

Thanks Benno & Chris.

I will add the settings into the IDE options and run some kind of survey about defaults.

My personal preferences are the same as Chris described.

Fixed jet-main 934f05e746f6

Added panel into options to allow user to choose the highlighting method, see attached screenshot.

Created attachment 153850 [details]
Screenshot

Integrated into 'main-silver', will be available in build *201505270357* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/934f05e746f6
User: Tomas Zezula <tzezula@netbeans.org>
Log: #245291:Please add Text selection for the result in the Go to File/Type/Symbol and so on dialog.