This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Comment Out a piece of code means to put a comment around it so that it does not work. The Comment Out action does the reverse in the editor toolbar.
Confirmed by american (Chris) and australian (Jack) native speakers, Comment Out means to put comment around something to make it ineffective. Comment In is not an english phrase.
OK, lets change it simply to Comment/Uncomment now.
Fixed. Changed to "Comment" and "Uncomment".
Sorry to be a pest, but I cannot help myself - the icons on the comment and uncomment are still reversed, why does the uncomment action display the "//" and the comment one does not? Should it perhaps be opposite?
I see - this was the effect of replacing the old icons with the new ones from Bruce. I have renamed the comment_out.gif and comment_in.gif to comment.gif and uncomment.gif which will hopefully avoid further confusion. The fix: 1) rename comment_out.gif to comment.gif and comment_in.gif to uncomment.gif in src/org/netbeans/modules/editor/resources/ 2) cvs remove comment_out.gif comment_in.gif 3) cvs add comment.gif uncomment.gif 4) apply the attached fix
Created attachment 6670 [details] Part of the fix
Integrated into main trunk Checking in libsrc/org/netbeans/editor/ext/ExtKit.java; /cvs/editor/libsrc/org/netbeans/editor/ext/ExtKit.java,v <-- ExtKit.java new revision: 1.30; previous revision: 1.29 done Processing log script arguments... More commits to come... RCS file: /cvs/editor/src/org/netbeans/modules/editor/resources/comment.gif,v done Checking in src/org/netbeans/modules/editor/resources/comment.gif; /cvs/editor/src/org/netbeans/modules/editor/resources/comment.gif,v <-- comment.gif initial revision: 1.1 done Removing src/org/netbeans/modules/editor/resources/comment_in.gif; /cvs/editor/src/org/netbeans/modules/editor/resources/comment_in.gif,v <-- comment_in.gif new revision: delete; previous revision: 1.3 done Removing src/org/netbeans/modules/editor/resources/comment_out.gif; /cvs/editor/src/org/netbeans/modules/editor/resources/comment_out.gif,v <-- comment_out.gif new revision: delete; previous revision: 1.3 done RCS file: /cvs/editor/src/org/netbeans/modules/editor/resources/uncomment.gif,v done Checking in src/org/netbeans/modules/editor/resources/uncomment.gif; /cvs/editor/src/org/netbeans/modules/editor/resources/uncomment.gif,v <-- uncomment.gif initial revision: 1.1 done
It seems OK to me in 200207160100.
Adding a diff hyperlink to the changed ExtKit: http://editor.netbeans.org/source/browse/editor/libsrc/org/netbeans/editor/ext/ExtKit.java.diff?r1=1.29&r2=1.30 Mato, could you please review the fix? Thanks.
Fixed in trunk.
Reviewed. The fix is OK. Mato
Integrated into release34.
Verified in 200207232340.
Resolved for 3.3.x or earlier, no new info since then -> closing.