This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 24119 - Runtime | VCS Commands Node popup menu
Summary: Runtime | VCS Commands Node popup menu
Status: CLOSED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Diff (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P3 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: UI
: 24117 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-05-28 09:32 UTC by iformanek
Modified: 2003-06-30 17:41 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description iformanek 2002-05-28 09:32:25 UTC
Runtime | VCS Commands Node popup menu should not contain 
the Tools action, since it only contains irrelevant Patch 
action.
Comment 1 Martin Entlicher 2002-05-30 13:33:56 UTC
This is in fact a flaw of Patch action.
Moving to the diff module...
Comment 2 Martin Entlicher 2002-05-30 13:37:15 UTC
Fixed in dev build May 31.
The Patch action was displayed on all FileObjects, now it's restricted
not to appear on FOs, that are in InstanceDataObjects and on the
default FS (with the exception of Templates, org and vcs/config
folders).
Comment 3 Martin Entlicher 2002-05-30 19:05:48 UTC
*** Issue 24117 has been marked as a duplicate of this issue. ***
Comment 4 iformanek 2002-05-31 09:26:53 UTC
SHould the VCS Commands Node contain the Tools action at 
all in its popup menu?
Comment 5 Martin Entlicher 2002-05-31 18:28:39 UTC
This is a good question. It's added automatically from
NodeOp.getDefaultActions(). This suggests, that Tools action have
sense on all Nodes, it depends on the actual action whether it wants
to be enabled on that node or not. This seems to be the common
approach.
The same applies to Processes node. Is it worth a change?
Comment 6 iformanek 2002-06-03 13:24:50 UTC
This is a two-edged sword; on one hand having the tools action there
makes it easy to extend almost anything, on the other hand, most
Cookie and Node actions compute their enabled state not taking all
cases into account, which results in actions present in inappropriate
places.


Perhaps the JavaDoc comment for isEnabled method in Node and
Cookieaction should suggest certain check patterns (such as do not
return true on SystemFileSystem, or check if the node is indeed
representing a file).
Comment 7 Jiri Kovalsky 2002-06-20 12:58:39 UTC
Works fine in development build #200206200100 of NetBeans 3.4.
Comment 8 Quality Engineering 2003-06-30 17:41:20 UTC
Resolved for 3.3.x or earlier, no new info since then -> closing.