This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 236458 - [Change Shortcut] IDE locked when closing Options while there is shortcut conflict
Summary: [Change Shortcut] IDE locked when closing Options while there is shortcut con...
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Key bindings (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P2 normal (vote)
Assignee: Svata Dedic
URL:
Keywords:
: 237425 237741 238103 238452 (view as bug list)
Depends on:
Blocks: 241983
  Show dependency tree
 
Reported: 2013-09-27 10:07 UTC by ssazonov
Modified: 2014-02-18 14:13 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
step_01 (164.74 KB, image/png)
2013-09-27 10:08 UTC, ssazonov
Details
step_02 (121.08 KB, image/png)
2013-09-27 10:08 UTC, ssazonov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ssazonov 2013-09-27 10:07:40 UTC
1. Go to Tools > Option > Keymap

2. Select "Replace" and type new Shortcut "Ctrl+Shift+O", WITHOUT DESELECTING Shortcut area press "Ok"

>> Option dialog is closed and "Lengthy operation in progress" message dialog occures, which don't react on closing and blocks over NetBeans controls and have never done. So the only one solution I know is to kill NetBeans using Task manager. Of course all unsaved changes in projects have not been saved.

Product Version: NetBeans IDE 7.4 RC2 (Build 201309252201)
Java: 1.7.0_40; Java HotSpot(TM) Client VM 24.0-b56
Runtime: Java(TM) SE Runtime Environment 1.7.0_40-b43
System: Windows 7 version 6.1 running on x86; Cp1252; en_US (nb)
Comment 1 ssazonov 2013-09-27 10:08:03 UTC
Created attachment 140543 [details]
step_01
Comment 2 ssazonov 2013-09-27 10:08:20 UTC
Created attachment 140544 [details]
step_02
Comment 3 Jiri Prox 2013-09-27 11:21:33 UTC
Reproducible always if there is shortcut conflict
Comment 4 Marian Mirilovic 2013-09-27 14:26:53 UTC
and it works in NB 7.3.1

Milutin, please evaluate.
Comment 5 Jiri Prox 2013-10-21 14:28:15 UTC
*** Bug 237425 has been marked as a duplicate of this bug. ***
Comment 6 Svata Dedic 2013-10-22 09:54:16 UTC
This would be tough to fix; a background thread may use DialogDisplayer.notify() to prompt the user which in this case conflicts with  RunOffEDT implementation.
Comment 7 Jiri Prox 2013-10-22 10:12:37 UTC
In previous version, all unconfirmed changes (e.g. used didn't press enter after changing shortcut) was ignored. Can be this behavior restored?
Comment 8 Jiri Prox 2013-10-29 10:04:03 UTC
*** Bug 237741 has been marked as a duplicate of this bug. ***
Comment 9 funkygibbon 2013-11-07 22:27:11 UTC
*** Bug 238103 has been marked as a duplicate of this bug. ***
Comment 10 funkygibbon 2013-11-07 22:34:43 UTC
A functioning workaround is to clear the existing keybind, save changes with OK, then return the the screen and rebind the function to the new keybind.

Applying changes after clearing a keybind and attempting to remap that keybind
will still cause the lengthy operation dialogue.
Comment 11 Svata Dedic 2013-11-13 12:48:32 UTC
(In reply to Jiri Prox from comment #7)
> In previous version, all unconfirmed changes (e.g. used didn't press enter
> after changing shortcut) was ignored. Can be this behavior restored?

The behaviour (in keymap opts) is the same as in the previous release. But the option save itself runs now in non-EDT thread (this was the change). Potentially all options, that ask for confirmation on save are affected.

I've somewhat restored the behaviour in that conflicts are not saved if the unconfirmed shortcut is saved using OK / Apply, but it leads to an inconsistency or reopening an older defect.

Even watching out for focus lost on the input line (-> perform checks, display dialog and store the input line's contents into the model) was useless during the testing: once the nested dialog was fired, the event loop received an action performed on the button and the save was initiated.

Ultimately the defect's fix leads to a more sophisticated save protocol between Options dialog infrastructure and individual panes - all pending actions must be somehow given the chance to finish.

Fixed in trunk in rev http://hg.netbeans.org/jet-main/rev/2b74af6c46ca
Comment 12 Jiri Prox 2013-11-14 14:51:25 UTC
verified in the trunk
Comment 13 Jiri Prox 2013-11-29 16:53:19 UTC
*** Bug 238452 has been marked as a duplicate of this bug. ***