This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 235796 - Debug project action does not launch the browser on the 2nd invocation with different browser
Summary: Debug project action does not launch the browser on the 2nd invocation with d...
Status: RESOLVED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Maven (show other bugs)
Version: 7.4
Hardware: PC Mac OS X
: P2 normal (vote)
Assignee: Martin Janicek
URL:
Keywords: 7.4_HR_FIX, REGRESSION
Depends on:
Blocks:
 
Reported: 2013-09-11 09:22 UTC by Petr Jiricka
Modified: 2013-09-14 09:23 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2013-09-11 09:22:28 UTC 
Product Version: NetBeans IDE Dev (Build web-main-11577-on-20130911)
Java: 1.7.0_25; Java HotSpot(TM) 64-Bit Server VM 23.25-b01
Runtime: Java(TM) SE Runtime Environment 1.7.0_25-b15
System: Mac OS X version 10.7.5 running on x86_64; UTF-8; en_US (nb)

1. Create a new Maven web project (Java EE 7, GF target)
2. Set browser to Chrome with NB integration
3. Debug this project - it will be deployed and Chrome tab will be opened
4. Set browser to Firefox (Chrome debugging session will be disconnected)
5. Debug the project again

=> Firefox is not opened.
Comment 1 Martin Janicek 2013-09-12 09:08:52 UTC 
Fixed by web-main #82ff1d8973bd

I'm not able to reproduce the problem using steps from description, but would be good if you could try it on a "real" application. Thanks
Comment 2 Marian Mirilovic 2013-09-12 14:33:52 UTC 
7.4 candidate ?
Comment 3 Petr Jiricka 2013-09-12 14:47:14 UTC 
Not sure yet, cc'ing Stepan. Martin, do you know what's the exact impact and when this will happen? Does it happen in other scenarios too? If it's not risky, then I would put it in 7.4.

Also this is a regression since 7.3.x.
Comment 4 Stepan Zebra 2013-09-12 15:53:58 UTC 
(In reply to Martin Janicek from comment #1)
> Fixed by web-main #82ff1d8973bd
> 
> I'm not able to reproduce the problem using steps from description, but
> would be good if you could try it on a "real" application. Thanks

verified by QE

the second browser now opens with the Chess demo
Comment 5 Quality Engineering 2013-09-13 02:03:28 UTC 
Integrated into 'main-silver', will be available in build *201309130002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/82ff1d8973bd
User: Martin Janicek <mjanicek@netbeans.org>
Log: #235796 - Debug project action does not launch the browser on the 2nd invocation with different browser
Comment 6 Martin Janicek 2013-09-13 07:55:52 UTC 
(In reply to Petr Jiricka from comment #3)
> Not sure yet, cc'ing Stepan. Martin, do you know what's the exact impact and
> when this will happen? Does it happen in other scenarios too? 

I'm not aware of any other case than the one you described

> If it's not risky, then I would put it in 7.4.

It's 100% safe, I'll do that
Comment 7 Martin Janicek 2013-09-13 08:23:16 UTC 
Martin, may I ask you for the patch review? Thanks!
Comment 8 Martin Fousek 2013-09-13 08:49:04 UTC 
(In reply to Martin Janicek from comment #7)
> Martin, may I ask you for the patch review? Thanks!

I can confirm that it's safe from view of possible regression.

But I would be worry from catching exceptions without information. I think that it could hide another issue in the future. I vote at least for logging that information with the INFO level. But it looks safe for integration in any shape.
Comment 9 Martin Janicek 2013-09-13 09:10:10 UTC 
Make sense, thanks. Done in web-main #4a32cd34faab
I'll send an email to reviewers and integrate both changesets into the release74 later today
Comment 10 Martin Fousek 2013-09-13 09:16:30 UTC 
(In reply to Martin Janicek from comment #9)
> Make sense, thanks. Done in web-main #4a32cd34faab

Looks great, thanks.
Comment 11 Quality Engineering 2013-09-14 05:14:10 UTC 
Integrated into 'main-silver', will be available in build *201309140002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/4a32cd34faab
User: Martin Janicek <mjanicek@netbeans.org>
Log: #235796 - Logging improved
Comment 12 Martin Janicek 2013-09-14 09:23:45 UTC 
Both change-sets grafted:

releases #bf60db90f70a
releases #864840bc4434