This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 235589 - Failing org.netbeans.modules.glassfish.common.GlassfishInstanceTest.testCreate_10args
Summary: Failing org.netbeans.modules.glassfish.common.GlassfishInstanceTest.testCreat...
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P1 normal (vote)
Assignee: TomasKraus
URL:
Keywords: 7.4_HR_FIX, TEST
Depends on:
Blocks:
 
Reported: 2013-09-06 08:43 UTC by Jiri Skrivanek
Modified: 2013-09-10 05:00 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Skrivanek 2013-09-06 08:43:50 UTC 
Please, fix failing org.netbeans.modules.glassfish.common.GlassfishInstanceTest.testCreate_10args. It opens dialog with message

<html>Unable to retrieve version of  instance installed in .<br/>Please make sure that this server is GlassFish 3.0 or later and that server is registered properly in NetBeans.<html>

To reproduce:

ant -k -f glassfish.common test test-generate-html -Dtest.includes=**/GlassfishInstanceTest.class
Comment 1 TomasKraus 2013-09-06 11:32:43 UTC 
OK. Looks like something is pointing to wrong directory or damaged GlassFish installation. This dialog means that registered instance was not recognized.
Comment 2 TomasKraus 2013-09-06 12:36:37 UTC 
This test method is trying to create an empty server instance providing empty string as values. This can't work for 7.4 because GlassfishInstance contains popup window to troll user when such invalid instance is being created.

Every instance of GlassfishInstance class should point to valid server installation.

Commenting out this test because it can't verify proper functionality of GlassfishInstance.create methods.
Comment 3 TomasKraus 2013-09-06 12:48:03 UTC 
Checked into web-main:
----------------------
changeset:   262774:86f41e8c2a7e
summary:     #235589 - Disabled test that cannot work with
             7.4 GlassfishInstance constructor.
Comment 4 TomasKraus 2013-09-06 12:52:26 UTC 
Jiri,

I need to build some integration tests infrastructure with real GlassFish servers available for Hudson job. 3.1.2.2 and 4.0/4.0.1 would be great. Do you think it's possible to do that?
Comment 5 Quality Engineering 2013-09-07 03:42:47 UTC 
Integrated into 'main-silver', will be available in build *201309070001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/86f41e8c2a7e
User: Tomas Kraus <TomasKraus@netbeans.org>
Log: #235589 - Disabled test that cannot work with 7.4 GlassfishInstance constructor.
Comment 6 Jiri Skrivanek 2013-09-09 07:37:14 UTC 
Ok, the test is dependent on environment configuration. I removed this test from stable test distribution. Now you can have your test in repository and run it locally.

http://hg.netbeans.org/core-main/rev/e235dc41b6e3
http://hg.netbeans.org/releases/rev/703f655038f9
Comment 7 Quality Engineering 2013-09-10 05:00:22 UTC 
Integrated into 'main-silver', will be available in build *201309100337* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/e235dc41b6e3
User: Jiri Skrivanek <jskrivanek@netbeans.org>
Log: #235589 - Test excluded from stable test distribution because it is server dependent.