This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 23551 - nodes within Options... Templates need unique help IDs
Summary: nodes within Options... Templates need unique help IDs
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P3 blocker (vote)
Assignee: Jiri Rechtacek
URL:
Keywords:
Depends on: 40146
Blocks:
  Show dependency tree
 
Reported: 2002-05-15 16:59 UTC by Patrick Keegan
Modified: 2008-12-22 17:50 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
a hot fix (2.61 KB, patch)
2002-07-04 16:11 UTC, Jiri Rechtacek
Details | Diff
a better fix where helpID attribute in layer is used (3.97 KB, patch)
2002-07-04 17:28 UTC, Jiri Rechtacek
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Keegan 2002-05-15 16:59:27 UTC
Currently, all nodes within Options | Source Creation and Management | Templates have help 
IDs that are not specific to the template context. Options | Source Creation and Management | 
Templates has org.netbeans.core.ui.UINodes$TemplatesNode, which is fine, but the nodes 
within have help IDs such as org.openide.loaders.DataFolder and  
org.openide.loaders.InstanceDataObject, which are not specific to the template context.

For now, it is probably enough to create one new ID and give that ID to all subnodes (all 
folders and instances). However, if feasible, it would be nice to have two additional IDs
- one for Templates | Filesystems (and all subnodes)
- one for Templates | Services (and all subnodes)
since these are much different kinds of templates and might require a different help page 
(generally describing use of these kinds of templates).
Comment 1 Jiri Rechtacek 2002-07-04 16:11:31 UTC
Created attachment 6530 [details]
a hot fix
Comment 2 Jiri Rechtacek 2002-07-04 16:22:02 UTC
There is a hot fix. Templates are recognized by display name in
OptionPanel, tree new ids are created:
1. for all subnodes of Templates category
2. one for Filesystems in Templates folder
3. one for Services in Templates folder

Better way might be ask for helpId from layer where the templates are
declared.
Comment 3 Jiri Rechtacek 2002-07-04 17:28:50 UTC
Created attachment 6531 [details]
a better fix where helpID attribute in layer is used
Comment 4 Jiri Rechtacek 2002-07-08 10:20:02 UTC
fixed, add three helpIds:
- for all subnodes of Templates category =
"org.netbeans.core.actions.OptionsAction$TemplatesSubnode"
- for Filesystems node in Templates
folder"org.netbeans.core.actions.OptionsAction$TemplatesSubnodeServices"
- for Services node in Templates folder
"org.netbeans.core.actions.OptionsAction$TemplatesSubnodeFilesystems"
Comment 5 Patrick Keegan 2003-07-08 16:21:24 UTC
Oops, it looks like this issue isn't completely fixed. The folders
have correct IDs, but the instances within the folders take the ID of
the data object, which is wrong. The template nodes should have IDs
related to the IDs that their containing folders do. E.g., the
templates within any folder that has the ID
"org.netbeans.core.actions.OptionsAction$TemplatesSubnode" should have
that ID, or something more specific like
"org.netbeans.core.actions.OptionsAction$TemplatesSubnodeInstance"
Comment 6 Jiri Rechtacek 2004-02-16 17:21:00 UTC
fixed, now are the help ids set:
Node: Options | Source Creation and Management | Templates <-> help
id: org.netbeans.core.actions.OptionsAction$Templates

Options | Source Creation and Management | Templates | Other <->
org.netbeans.core.actions.OptionsAction$TemplatesSubnode

Options | Source Creation and Management | Templates | Other |
children <-> org.netbeans.core.actions.OptionsAction$TemplatesSubnode


Options | Source Creation and Management | Templates | Services <->
org.netbeans.core.actions.OptionsAction$TemplatesSubnodeServices


Options | Source Creation and Management | Templates | Services |
children <->
org.netbeans.core.actions.OptionsAction$TemplatesSubnodeServices

Still is valid if any helpId is declared in layer then will be
preffred. Hope it helps.
Comment 7 Patrick Keegan 2004-02-18 00:16:41 UTC
verified in build 200402171900. Thanks, Jirka.