This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 234830 - I18N: Bundle_nb.properties not included in l10n-kit
Summary: I18N: Bundle_nb.properties not included in l10n-kit
Status: VERIFIED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 7.4
Hardware: All All
: P2 normal (vote)
Assignee: Jiri Rechtacek
URL:
Keywords: 7.4_HR_FIX, REGRESSION
Depends on:
Blocks:
 
Reported: 2013-08-23 02:26 UTC by Masaki Katakai
Modified: 2013-09-06 08:53 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2013-08-23 02:26:46 UTC 
I noticed all Bundle_nb.properties files are not included in l10n-kit.

http://smetiste.cz.oracle.com/builds/netbeans/trunk/daily/2013-08-22_23-00-42/zip/ide-l10n-201308222300.zip

Could you please evaluate and fix quickly?
I noticed these should be localized,
e.g. 

nb/ide-branding/locale/autoupdate-ui_nb/org/netbeans/modules/autoupdate/ui/wizards/Bundle_nb.properties

will be used at plugin installation.

I confirmed there was no problem at 7.0.1 l10n-kit.
I can find these Bundle_nb.properties.

bash-4.1$ unzip -l ide-l10n-201107282000.zip | grep Bundle_nb.properties
     2978  07-28-2011 20:45   nb/ide-branding/netbeans/core/locale/core_nb/org/netbeans/core/startup/Bundle_nb.properties
     2547  07-28-2011 20:45   nb/ide-branding/ext/locale/updater_nb/org/netbeans/updater/Bundle_nb.properties
      122  07-28-2011 20:45   nb/ide-branding/locale/org-netbeans-core-ui_nb/org/netbeans/core/ui/sampler/Bundle_nb.properties
     2347  07-28-2011 20:45   nb/ide-branding/locale/org-netbeans-core-windows_nb/org/netbeans/core/windows/view/ui/Bundle_nb.properties
     2534  07-28-2011 20:45   nb/ide-branding/locale/org-netbeans-core_nb/org/netbeans/core/Bundle_nb.properties
      749  07-28-2011 20:45   nb/ide-branding/locale/autoupdate-ui_nb/org/netbeans/modules/autoupdate/ui/Bundle_nb.properties
      210  07-28-2011 20:45   nb/ide-branding/locale/autoupdate-ui_nb/org/netbeans/modules/autoupdate/ui/actions/Bundle_nb.properties
     3892  07-28-2011 20:45   nb/ide-branding/locale/autoupdate-ui_nb/org/netbeans/modules/autoupdate/ui/wizards/Bundle_nb.properties
      406  07-28-2011 20:45   nb/ide-branding/locale/options-api_nb/org/netbeans/modules/options/export/Bundle_nb.properties
     2413  07-28-2011 20:45   nb/ide-branding/locale/org-netbeans-spi-quicksearch_nb/org/netbeans/modules/quicksearch/web/Bundle_nb.properties
bash-4.1$
Comment 1 Jiri Rechtacek 2013-09-05 10:03:10 UTC 
The regression was caused by http://hg.netbeans.org/releases/rev/5eeba164a793 - since NetBeans 7.3.

Needs exclude locales but left branding token.
Comment 2 Jiri Rechtacek 2013-09-05 16:53:55 UTC 
Fixed in trunk - http://hg.netbeans.org/core-main/rev/bba9c505b8fc

Masaki, could you verify the fix, it should be available in nightly dev build in a few days? Once verified I'm going to backport to 7.4 release. Thanks
Comment 3 Masaki Katakai 2013-09-06 02:31:41 UTC 
Hi Jiri,

Thank you very much! I have verified your fix in 201309060001.
Great!

However, it seems that 'Bundle_noi18n.properties' are also
included now. I understand we don't need to localize them.

Please integrate your fix to 74 branch and after 7.4
you can find to exclude Bundle_noi18n.properties.

544a545
> ./enterprise/web-jspparser/ext/jsp-parser-ext/org/netbeans/modules/web/jspparser_ext/Bundle.properties
874a876
> ./ide/db/db/org/netbeans/modules/db/resources/Bundle_noi18n.properties
1407a1410
> ./java/dbschema/dbschema/org/netbeans/modules/dbschema/nodes/Bundle_noi18n.properties
1551d1553
< ./java/java-helpset/java-helpset/org/netbeans/modules/java/helpset/Bundle.properties
1915a1918
> ./nb/ide-branding/ext/locale/updater_nb/org/netbeans/updater/Bundle_nb.properties
1916a1920,1932
> ./nb/ide-branding/locale/autoupdate-ui_nb/org/netbeans/modules/autoupdate/ui/Bundle_nb.properties
> ./nb/ide-branding/locale/autoupdate-ui_nb/org/netbeans/modules/autoupdate/ui/actions/Bundle_nb.properties
> ./nb/ide-branding/locale/autoupdate-ui_nb/org/netbeans/modules/autoupdate/ui/wizards/Bundle_nb.properties
> ./nb/ide-branding/locale/options-api_nb/org/netbeans/modules/options/export/Bundle_nb.properties
> ./nb/ide-branding/locale/org-netbeans-core-netigso_nb/org/netbeans/core/netigso/Bundle_nb.properties
> ./nb/ide-branding/locale/org-netbeans-core-ui_nb/org/netbeans/core/ui/sampler/Bundle_nb.properties
> ./nb/ide-branding/locale/org-netbeans-core-windows_nb/org/netbeans/core/windows/Bundle_nb.properties
> ./nb/ide-branding/locale/org-netbeans-core-windows_nb/org/netbeans/core/windows/view/ui/Bundle_nb.properties
> ./nb/ide-branding/locale/org-netbeans-core_nb/org/netbeans/core/Bundle_nb.properties
> ./nb/ide-branding/locale/org-netbeans-spi-quicksearch_nb/org/netbeans/modules/quicksearch/web/Bundle_nb.properties
> ./nb/ide-branding/locale/uihandler_nb/org/netbeans/modules/exceptions/Bundle_nb.properties
> ./nb/ide-branding/locale/uihandler_nb/org/netbeans/modules/uihandler/Bundle_nb.properties
> ./nb/ide-branding/netbeans/core/locale/core_nb/org/netbeans/core/startup/Bundle_nb.properties
2117d2132
< ./platform/favorites/favorites/org/netbeans/modules/favorites/templates/Bundle.properties
2239a2255,2256
> ./platform/templates/templates/org/netbeans/modules/templates/Bundle.properties
> ./platform/templates/templates/org/netbeans/modules/templates/ui/Bundle.properties
Comment 4 Jiri Rechtacek 2013-09-06 08:26:43 UTC 
(In reply to Masaki Katakai from comment #3)
> Please integrate your fix to 74 branch and after 7.4
I'm integrate today.

> you can find to exclude Bundle_noi18n.properties.
Filed as issue 235587
Comment 5 Jiri Rechtacek 2013-09-06 08:53:41 UTC 
release74 - http://hg.netbeans.org/releases/rev/92a1c81a8903