This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Created attachment 137973 [details] Shows issue using Dark NImbus Same issue like https://netbeans.org/bugzilla/show_bug.cgi?id=231721 happens using Dark Nimbus * open patch file ACTUAL: blue text on dark background - see screenshot EXPECTED: better contrast --- Dark NImbus with Norway Product Version: NetBeans IDE Dev (Build 201307262300) Java: 1.7.0_25; Java HotSpot(TM) 64-Bit Server VM 23.25-b01 Runtime: Java(TM) SE Runtime Environment 1.7.0_25-b16 System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)
what editor color scheme do you use? Diff editor colors are not affected by selected laf but rather by the editor colors profile. In Norway Today dark theme it's ok. See the screenshot. Please attach the same screenshot from your IDE.
Created attachment 137982 [details] diff default colors in Norway Today
maybe the colors in Norway scheme are cached, please try to click on Restore or run with fresh userdir and report. Thanks
Created attachment 138015 [details] Diff vs. Patch colors (In reply to comment #3) > maybe the colors in Norway scheme are cached, please try to click on Restore or > run with fresh userdir and report. Thanks I tried it and in your screenshot there is the same issue. I am complaining about the "blue color on dark background". This color combination isn't readable IMHO. I propose to use the same colors as used in diff view. See screenshot. Does this make sense?
(In reply to comment #4) > I propose to use the same colors as used in diff view. See screenshot. Some more detailed: I propose to use the same colors (foreground AND background) as used in diff view.
> (In reply to comment #4) > Some more detailed: I propose to use the same colors (foreground AND background) as used in diff view. It doesn't seem right, it is readable, yes. But for me the removed/added sections almost blend together and i cannot tell the difference between them. I suggest changing blue to green (similar to this http://www.malloc.co/wp-content/uploads/2012/10/Screen-Shot-2012-10-17-at-10.12.56-PM.png)
Created attachment 138036 [details] weird colors
what about diffeditor2.png as a suggestion? Changing blue to green?
Created attachment 138037 [details] suggestion
(In reply to comment #8) > what about diffeditor2.png as a suggestion? Changing blue to green? Yes, the contrast is much better! Do you like to change the diff-colors too, so that it looks consistent?! > http://www.malloc.co/wp-content/uploads/2012/10/Screen-Shot-2012-10-17-at-10.12.56-PM.png The contrast in the screenshot is also OK.
(In reply to comment #10) > Do you like to change the diff-colors too, so > that it looks consistent?! What color do you mean? Background colors in the diff view on https://netbeans.org/bugzilla/attachment.cgi?id=138015 ? They are also green/red although much darker.
fix: http://hg.netbeans.org/core-main/rev/66585820104a
Integrated into 'main-silver', will be available in build *201308012300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/66585820104a User: Ondrej Vrabec <ovrabec@netbeans.org> Log: #233624 - [dark] [nimbus] patch in editor is not readable due to colors
Verified in 201308240953