This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 233380 - SVN highlighting not updated after an external commit
Summary: SVN highlighting not updated after an external commit
Status: RESOLVED DUPLICATE of bug 153559
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Subversion (show other bugs)
Version: 7.3.1
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-25 08:32 UTC by vbeffa
Modified: 2015-04-10 17:28 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
messages log file (44.50 KB, application/octet-stream)
2013-07-25 10:27 UTC, vbeffa
Details
messages log file (49.33 KB, application/octet-stream)
2013-07-26 08:13 UTC, vbeffa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description vbeffa 2013-07-25 08:32:50 UTC
After an SVN commit, the left sidebar coloring for the changed/removed/added lines in a file does not update. It updates only after closing and reopening the file in the editor.

Furthermore, the blue color of the filename in the tab does not change back to black until the editor is restarted.
Comment 1 Marian Mirilovic 2013-07-25 10:15:22 UTC
Could you please attach your messages.log file and reopen ? Thanks in advance.
http://wiki.netbeans.org/FaqLogMessagesFile
Comment 2 vbeffa 2013-07-25 10:27:59 UTC
Created attachment 137773 [details]
messages log file
Comment 3 vbeffa 2013-07-25 10:28:38 UTC
I had the wrong NB version - it's 7.3.1, not 7.4.
Comment 4 Ondrej Vrabec 2013-07-25 10:59:22 UTC
Is it reproducible for every file?
> Furthermore, the blue color of the filename in the tab does not change back to
> black until the editor is restarted.
Does it change in the Projects/Files view?

Please run with -J-Dorg.netbeans.modules.versioning.ui.diff.DiffSidebarManager.level=-1 and -J-Dorg.netbeans.modules.subversion.ui.commit.CommitAction.level=-1, try a commit and attach the messages.log after a while when the status does not change.
Comment 5 Ondrej Vrabec 2013-07-26 08:02:43 UTC
reopen when you provide the requested information, thanks.
Comment 6 vbeffa 2013-07-26 08:12:46 UTC
(In reply to comment #4)
> Is it reproducible for every file?
> > Furthermore, the blue color of the filename in the tab does not change back to
> > black until the editor is restarted.
> Does it change in the Projects/Files view?
> 
> Please run with
> -J-Dorg.netbeans.modules.versioning.ui.diff.DiffSidebarManager.level=-1 and
> -J-Dorg.netbeans.modules.subversion.ui.commit.CommitAction.level=-1, try a
> commit and attach the messages.log after a while when the status does not
> change.

No, the color remains blue in the Projects and Files views, even after closing and reopening the file.
Comment 7 vbeffa 2013-07-26 08:13:49 UTC
Created attachment 137842 [details]
messages log file

Ran NB with

-J-Dorg.netbeans.modules.versioning.ui.diff.DiffSidebarManager.level=-1
-J-Dorg.netbeans.modules.subversion.ui.commit.CommitAction.level=-1

options set in netbeans.conf.
Comment 8 vbeffa 2013-07-26 08:14:13 UTC
See comments and new attachment below.
Comment 9 Ondrej Vrabec 2013-07-26 08:35:50 UTC
There is absolutely no trace of any commit-related log message in the log. Did you try to commit as i asked? Otherwise the log is useless.

Anyway, again, does it happen for all files?
If you run Subversion -> Show Changes action, what status displayed for the file?
Can you also try to:
1) make some modification in a file -> the file should turn blue and the diff sidebar in editor should show the modification, right?
2) run Subversion -> Revert Modifications -> everything should turn to uptodate again, right?
Comment 10 vbeffa 2013-07-26 09:09:31 UTC
(In reply to comment #9)
> There is absolutely no trace of any commit-related log message in the log. Did
> you try to commit as i asked? Otherwise the log is useless.
> 
> Anyway, again, does it happen for all files?
> If you run Subversion -> Show Changes action, what status displayed for the
> file?
> Can you also try to:
> 1) make some modification in a file -> the file should turn blue and the diff
> sidebar in editor should show the modification, right?
> 2) run Subversion -> Revert Modifications -> everything should turn to uptodate
> again, right?

I didn't do the commit from inside NB, I did it from an external program. But it gets the diff information from the metadata files in the .svn folder, doesn't it? It seems like it does, because it correctly updates the sidebar highlighting.
Comment 11 Ondrej Vrabec 2013-07-26 09:13:21 UTC
> I didn't do the commit from inside NB, I did it from an external program. But
> it gets the diff information from the metadata files in the .svn folder,
> doesn't it? It seems like it does, because it correctly updates the sidebar
> highlighting.
No it doesn't. Subversion module does not listen on external changes. If you do any external operation (such as a commit) you should always resync in the IDE with Subversion -> Show Changes action. Thanks for understanding.
Comment 12 vbeffa 2013-07-26 09:19:40 UTC
(In reply to comment #11)
> > I didn't do the commit from inside NB, I did it from an external program. But
> > it gets the diff information from the metadata files in the .svn folder,
> > doesn't it? It seems like it does, because it correctly updates the sidebar
> > highlighting.
> No it doesn't. Subversion module does not listen on external changes. If you do
> any external operation (such as a commit) you should always resync in the IDE
> with Subversion -> Show Changes action. Thanks for understanding.

If it doesn't, how does the sidebar highlighting get automatically updated? I can understand having to manually refresh the status, but as it is now, the coloring gets partly (and thus inconsistently) updated.
Comment 13 Ondrej Vrabec 2013-07-26 09:23:26 UTC
> If it doesn't, how does the sidebar highlighting get automatically updated?
Does it? In the description of the issue you said it didn't:
> After an SVN commit, the left sidebar coloring for the changed/removed/added lines in a file does not update.
Comment 14 vbeffa 2013-07-26 09:54:03 UTC
(In reply to comment #13)
> > If it doesn't, how does the sidebar highlighting get automatically updated?
> Does it? In the description of the issue you said it didn't:
> > After an SVN commit, the left sidebar coloring for the changed/removed/added lines in a file does not update.

Sorry, not completely automatically, but reopening the file updates the sidebar coloring without using the Show Changes command. The filename coloring doesn't update until you run the command. So there's a slight inconsistency there...

Wouldn't it be possible to add a "Scan for external changes" option as NB already does for files modified outside the editor?
Comment 15 Ondrej Vrabec 2013-07-26 10:06:46 UTC
(In reply to comment #14)
> Sorry, not completely automatically, but reopening the file updates the sidebar
> coloring without using the Show Changes command. The filename coloring doesn't
> update until you run the command. So there's a slight inconsistency there...
The diff sidebar is updated in this case simply because it is always freshly initialized when you open a file. It's not cached anywhere as file statuses are.

> Wouldn't it be possible to add a "Scan for external changes" option as NB
> already does for files modified outside the editor?
Probably. With subversion 1.7 and its centralized metadata listening on external changes in metadata could be implemented. It would probably suffer from dramatic performance issues on large projects but you could turn it on manually on your own risk.
If you really think it would be useful, reopen and change Issue Type to enhancement.
Comment 16 vbeffa 2013-07-29 08:13:54 UTC
Enhancement request:

Add a "Scan for external changes" option for source control highlighting as NB already does for files modified outside the editor.
Comment 17 Ondrej Vrabec 2015-04-10 17:28:41 UTC

*** This bug has been marked as a duplicate of bug 153559 ***