This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Created attachment 137583 [details] Shows the issue The terminal toolbar buttons on the left side take too much vertical space when using Dark Nimbus. See screenshot. It works using Dark Metal. Product Version: NetBeans IDE Dev (Build 201307212300) Java: 1.7.0_25; Java HotSpot(TM) 64-Bit Server VM 23.25-b01 Runtime: Java(TM) SE Runtime Environment 1.7.0_25-b16 System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)
The problem is that there is a moment when two toolbars are drawn. BTW, how did you get this screenshot? I cannot reproduce this behavior. Or, to be more precise, I can see the same picture, but it stays for a very short period of time. After some refresh everything comes to order. To see this effect one can put a breakpoint to line 127 (method doWork()) of TerminalSupportImpl.java from dlight.terminal module. There is an actions toolbar that belongs to a terminal (TerminalContainerCommon.actionBar) and there is another one that comes from TerminalContainerTopComponent (TerminalContainerTopComponent.actionsBar). As far as I understand the latter one was introduced because there was an idea to have a toolbar that is _always_ visible (even if no terminal container is open). So terminal itself is created without any additional actions (it's toolbar is empty) and TerminalContainerTopComponent.actionsBar is populated with two actions "open Local Terminal/open Remote Terminal". When TerminalContainerTopComponent is opened it invokes 'open Local Terminal' action. This action, in turn, opens a TerminalContainer, and goes off-EDT. At this moment TerminalContainer's toolbar is drawn (empty, but it's border is visible). Then (line 171 [term.getIO(tabTitle, null, ioContainer)] of TerminalSupportImpl.java) initiates a logic that sets terminal container's actions to null. And this, in turn makes toolbar invisible (TerminalContainerCommon.java:519). As a possible fix I would suggest to create TerminalContainer's toolbar initially invisible. diff --git a/terminal/src/org/netbeans/modules/terminal/iocontainer/TerminalContainerCommon.java b/terminal/src/org/netbeans/modules/terminal/iocontainer/TerminalContainerCommon.java --- a/terminal/src/org/netbeans/modules/terminal/iocontainer/TerminalContainerCommon.java +++ b/terminal/src/org/netbeans/modules/terminal/iocontainer/TerminalContainerCommon.java @@ -376,6 +376,7 @@ actionBar.setFloatable(false); fixSize(actionBar); add(actionBar, BorderLayout.WEST); + actionBar.setVisible(false); findBar = new FindBar(new FindBar.Owner() {
http://hg.netbeans.org/cnd-main/rev/abd61d58b0f8
Integrated into 'main-silver', will be available in build *201307252300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/abd61d58b0f8 User: Andrew Krasny <akrasny@netbeans.org> Log: Bug #233206 - [dark] [nimbus] terminal buttons need to much vertical space
Verified in 201307262300