This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Created attachment 137172 [details] screenshot Please check the screenshot, parameter value is (I think) difficult to read on this background. I tried RGB[0, 153, 51] and it looks better this way (again, In my point of view) Product Version: NetBeans IDE Dev (Build 201307152300)
The settings are inherited from editor's default values - markup-attribute-value
I agree with Vlada, that the markup-attribute-value color for dark themes could be quite lighter (#C10087 for example)
Ok, thank you. http://hg.netbeans.org/jet-main/rev/df4d8bd0c4fc
Integrated into 'main-silver', will be available in build *201307192300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/df4d8bd0c4fc User: Milutin Kristofic <mkristofic@netbeans.org> Log: #232760 - [dark theme] Hard to read paramater value in Norway Today
It seems like there is no difference, color is RGB(153,0,107) - #99006B in latest trunk build and in build from July 19, the value is the same Product Version: NetBeans IDE Dev (Build 201307212300) Java: 1.7.0_40-ea; Java HotSpot(TM) Client VM 24.0-b52 Runtime: Java(TM) SE Runtime Environment 1.7.0_40-ea-b33 System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
*** Bug 233135 has been marked as a duplicate of this bug. ***
Please notice issue 233135 where reporter also complains about readability of highlighted parameter. Thank you
I see the foreground 193, 0, 135 in jet-main build. Just try newer version. What do you recommend for highlighted parameter? Is it still wrong with newer color for parameter? I am not using this profile.
I did try newer version, please see comment #5, used build is 201307212300, according to comment #4 the change should be already in 201307192300. I checked colors in "All languages" and there is [193,0,135] for Markup Attribute Value, but it doesn't seem to have any effect in this case (change to some other color is not reflected in editor). What changes the color in this case is "Parameter Value" category in HTML language settings. And it is still[153,0,107]. So perhaps it needs to be resolved specifically for HTML as well? Ad the highlighted text: I think it is better with the new color.
> I checked colors in "All languages" and there is [193,0,135] for Markup > Attribute Value, but it doesn't seem to have any effect in this case (change to > some other color is not reflected in editor). > > What changes the color in this case is "Parameter Value" category in HTML > language settings. And it is still[153,0,107]. So perhaps it needs to be > resolved specifically for HTML as well? This is a problem of html editor which doesn't default to the generic colors in the dark themes (the inheritance works in default scheme only).
(In reply to comment #10) > > I checked colors in "All languages" and there is [193,0,135] for Markup > > Attribute Value, but it doesn't seem to have any effect in this case (change to > > some other color is not reflected in editor). > > > > What changes the color in this case is "Parameter Value" category in HTML > > language settings. And it is still[153,0,107]. So perhaps it needs to be > > resolved specifically for HTML as well? > This is a problem of html editor which doesn't default to the generic colors in > the dark themes (the inheritance works in default scheme only). Hmm, not exactly. The HTML default colors are already defined in defaults module in the file BlueTheme-HTML-fontsColors.xml. There is: <fontcolor name="value" foreColor="ff99006b" default="default"/> which should be IMO changed to: <fontcolor name="value" default="markup-attribute-value"/> same should be done for the other generic categories (element, attribute). I used to think the colors for the dark themes are somehow derived from the default theme and wanted to override them by adding the default colors into the dark theme coloring files in html.editor. As I found out all the colors are hardcoded in the defaults module, passing back to editor.
Ok, sorry for my mistake, I checked only general fonts and colors. All other profiles has html value default set to markup-attribute-value. So I change it as Marek suggested. http://hg.netbeans.org/jet-main/rev/29c535bd5d69
Thank you, the highlighted value also seems to look better to me. Product Version: NetBeans IDE Dev (Build 201307242300) Java: 1.7.0_40-ea; Java HotSpot(TM) Client VM 24.0-b52 Runtime: Java(TM) SE Runtime Environment 1.7.0_40-ea-b33 System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)