This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 23203 - CVS: "Patch" command does not have default radio buttons selected.
Summary: CVS: "Patch" command does not have default radio buttons selected.
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: -FFJ-
Hardware: PC Windows ME/2000
: P4 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on: 37252
Blocks:
  Show dependency tree
 
Reported: 2002-05-07 12:34 UTC by Jiri Kovalsky
Modified: 2004-07-19 12:39 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Kovalsky 2002-05-07 12:34:37 UTC
Forte for Java 4.0 Community Edition #020506
Windows 2000 with JDK 1.4 b#92

Description:
============
Default appearance of Patch dialog is very
strange. There are three radio button groups and
none of them have some default selection. I also
think that "Top two ..." checkbox should disable
everything below this widget.

Steps to reproduce:
===================
1. Mount CVS filesystem using Command-line Client.
2. Right click some file and choose "CVS|Patch"
command.
3. Note that none of the radio buttons is selected.
4. Also note that you can select revisions
although "Top two ..." checkbox is checked.
Comment 1 Jiri Kovalsky 2002-05-07 13:07:50 UTC
I have two more comments here:

1. Both "Date" textfields are not working because there are "-D"
options missing in execution string. It means that command always
fails in such case.

2. Saving history of used options and values is really funny. I have
never got the same setting when pressing "Previous" button. It does
not work at all.
Comment 2 Martin Entlicher 2002-05-09 11:59:52 UTC
The input descriptor and execution string of PATCH command fixed.

The problem with history reload needs to be fixed generally in
VariableInputDialog. Starting to work on this...
Comment 3 Martin Entlicher 2002-05-09 13:40:17 UTC
The history should be reloaded O.K. in dev build May 10.
Comment 4 Jiri Kovalsky 2002-05-10 11:18:27 UTC
I have found one minor problem. The second "Select..." button gets
enabled sometimes although its radio button is turned off. Here is the
repro-case:

1. Mount new CVS filesystem using Command-line Client.
2. Invoke "CVS|Patch" on some file and push "OK" button.
3. Invoke it again and using "Select..." buttons choose 1.1 and 1.2 as
revisions. Push "OK" button.
4. Invoke the command again and push "Previous" twice.
5. You will see that "Revision or Tag 2" textfield is enabled together
with its "Select..." button although their radio button is disabled.

Trying to verify in development build #200205100630 of NetBeans 3.4.
Comment 5 Jiri Kovalsky 2002-05-10 11:20:20 UTC
Of course, this is not P3 issue any more.
Comment 6 Martin Entlicher 2002-05-10 11:54:23 UTC
You really catch every small inconsistence :-)
I was able to reproduce it and know where the problem is, but the fix
will not be straightforward.
Comment 7 Marek Grummich 2002-07-22 11:58:46 UTC
Set target milestone to TBD
Comment 8 Martin Entlicher 2003-11-27 09:40:19 UTC
This is a problem in VariableInputDialog.
It may be the same problem that is described in issue #37252.
Comment 9 Martin Entlicher 2004-01-16 16:38:18 UTC
Issue #37252 is fixed, but there still remains one small problem:
The second "Select" button with it's textfield remains enabled even
though the corresponding radio button is disabled.
This happens when: "Revsion or Tag" is selected, then, "Revision or
Tag 2" is selected and then "Top two difs" is selected again.
The enable/disable logic does not work correctly for the sub-components.
Comment 10 Martin Entlicher 2004-01-19 09:55:17 UTC
The similar problem is visible also in the CVS customizer in some
situations. => This have higher priority.

The logic of enabling/disabling of components is still not sufficient.
Comment 11 Martin Entlicher 2004-01-19 10:04:52 UTC
Fixed in trunk:

/cvs/vcscore/src/org/netbeans/modules/vcscore/util/VariableInputDialog.java,v
 <--  VariableInputDialog.java
new revision: 1.68; previous revision: 1.67
Comment 12 Jiri Kovalsky 2004-07-19 12:39:54 UTC
No more comments here. Verified in development build #200407151800 of
NetBeans 4.0.