This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 230696 - Patch for: [Keymap] Export as html-button isn't aligned and has no mnemonic
Summary: Patch for: [Keymap] Export as html-button isn't aligned and has no mnemonic
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Key bindings (show other bugs)
Version: 7.4
Hardware: PC Windows XP
: P4 normal (vote)
Assignee: markiewb
URL:
Keywords: A11Y, PATCH_AVAILABLE
Depends on:
Blocks:
 
Reported: 2013-06-03 20:54 UTC by markiewb
Modified: 2013-06-13 12:13 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Shows the issue (44.21 KB, image/png)
2013-06-03 20:54 UTC, markiewb 		Details
Proposed patch (2.94 KB, patch)
2013-06-03 21:42 UTC, markiewb 		Details | Diff
Patch in action (41.41 KB, image/png)
2013-06-03 21:44 UTC, markiewb 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-06-03 20:54:15 UTC 
Created attachment 135291 [details]
Shows the issue

The "export current keymap as html" feature was introduced by [1].

ACTUAL: 
* the button isn't vertically aligned to the other "manage profiles" button
* the button has no mnemonic

See screenshot

EXPECTED:
* correct alignment of the "manage profiles" button (the export button seems to be correctly aligned to the dropdown)
* mnemonic for the "export as html" button

[1] https://netbeans.org/bugzilla/show_bug.cgi?id=226955
Comment 1 markiewb 2013-06-03 21:42:27 UTC 
Created attachment 135295 [details]
Proposed patch

I like to propose this simple patch to solve the issue.

Please review and commit if appropriate. Thank you!
Comment 2 markiewb 2013-06-03 21:44:29 UTC 
Created attachment 135296 [details]
Patch in action
Comment 3 Svata Dedic 2013-06-05 09:40:01 UTC 
Thanks ! Applied as revision http://hg.netbeans.org/jet-main/rev/c5ba9e896f66
Comment 4 Quality Engineering 2013-06-10 02:21:20 UTC 
Integrated into 'main-golden', will be available in build *201306100004* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c5ba9e896f66
User: Svata Dedic <sdedic@netbeans.org>
Log: #230696: Export button properly aligned, mnemonic added
Comment 5 markiewb 2013-06-13 12:13:13 UTC 
Verified 201306122301