This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229630 - Patch for: [Git reset] missing mnemonics for hard, soft, mixed
Summary: Patch for: [Git reset] missing mnemonics for hard, soft, mixed
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Git (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords: A11Y, PATCH_AVAILABLE
Depends on:
Blocks:
 
Reported: 2013-05-12 19:31 UTC by markiewb
Modified: 2013-08-12 21:02 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Shows the dialog with missing mnemonics (31.14 KB, image/png)
2013-05-12 19:31 UTC, markiewb 		Details
Proposed patch (1.09 KB, patch)
2013-05-12 21:16 UTC, markiewb 		Details | Diff
Shows clashes (26.62 KB, image/png)
2013-07-23 22:12 UTC, markiewb 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-05-12 19:31:20 UTC 
Created attachment 134336 [details]
Shows the dialog with missing mnemonics

ACTUAL in the Git reset dialog there are no mnemonics for the options hard, soft, mixed - see screenshot

EXPECTED mnemonics 

-----
NB 201305092300
Comment 1 markiewb 2013-05-12 21:16:52 UTC 
Created attachment 134340 [details]
Proposed patch

I like to propose this patch to solve the issue. It only adds the mnemonics to the options. There should be no conflicts within the dialog.

@Ondrej: Please review and commit, if appropriate. Thank you
Comment 2 Ondrej Vrabec 2013-05-13 11:19:28 UTC 
thanks, pushed as core-main #936dd561bafd
Comment 3 Quality Engineering 2013-05-15 02:30:04 UTC 
Integrated into 'main-golden', will be available in build *201305142300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/936dd561bafd
User: Benno Markiewicz <markiewb@netbeans.org>
Log: Issue #229630 - [Git reset] missing mnemonics for hard, soft, mixed
Comment 4 markiewb 2013-07-23 22:12:20 UTC 
Created attachment 137655 [details]
Shows clashes
Comment 5 markiewb 2013-07-23 22:13:04 UTC 
Sorry for reopening the issue. The mnemonic "h" is used twice. See screenshot https://netbeans.org/bugzilla/attachment.cgi?id=137655
Comment 6 markiewb 2013-07-23 22:14:25 UTC 
(In reply to comment #5)
> Sorry for reopening the issue. The mnemonic "h" is used twice. See screenshot
> https://netbeans.org/bugzilla/attachment.cgi?id=137655

And I am also sorry, because my patch didn't take this in account.
Comment 7 Ondrej Vrabec 2013-07-24 07:34:53 UTC 
fix: http://hg.netbeans.org/core-main/rev/cf1581eed038
Comment 8 Quality Engineering 2013-07-25 02:28:15 UTC 
Integrated into 'main-silver', will be available in build *201307242300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/cf1581eed038
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: #229630 - Patch for: [Git reset] missing mnemonics for hard, soft, mixed
Comment 9 markiewb 2013-08-12 21:02:21 UTC 
verified at least in 201308092300