This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229551 - Patch for: "Specify git repository location" dialog: Usability issues
Summary: Patch for: "Specify git repository location" dialog: Usability issues
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Git (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P4 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords: PATCH_AVAILABLE, USABILITY
Depends on:
Blocks:
 
Reported: 2013-05-09 17:15 UTC by markiewb
Modified: 2013-07-23 22:07 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Shows the dialog (67.59 KB, image/png)
2013-05-09 17:15 UTC, markiewb
Details
Patch for fixing the mnemonics issue (2.90 KB, patch)
2013-05-09 17:41 UTC, markiewb
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-05-09 17:15:44 UTC
Created attachment 134266 [details]
Shows the dialog

ACTUAL: 
* when opening the dialog the button "proxy configuration" has the focus - see screenshot
* the user cannot switch to the  fields "&User" / "&Password" via mnemonics

EXPECTED:
* when opening the dialog the textfield "User" has the input focus (because the main intent of the dialog is to ask for credentials)
* mnemonics for the fields "&User" / "&Password" work
Comment 1 markiewb 2013-05-09 17:41:47 UTC
Created attachment 134268 [details]
Patch for fixing the mnemonics issue

(In reply to comment #0)
> * mnemonics for the fields "&User" / "&Password" work

See the attached patch

> when opening the dialog the textfield "User" has the input focus (because the
main intent of the dialog is to ask for credentials)

I couldn't find the correct place in org.netbeans.modules.git.ui.repository.remote.RemoteRepository to insert a simple textField.requestFocusInWindow().
Comment 2 Ondrej Vrabec 2013-05-10 13:44:48 UTC
fix: http://hg.netbeans.org/core-main/rev/c28a838f5c2a
Comment 3 markiewb 2013-05-10 16:12:35 UTC
(In reply to comment #2)
> fix: http://hg.netbeans.org/core-main/rev/c28a838f5c2a
Thanks Ondrej!
Comment 4 Quality Engineering 2013-05-11 02:32:21 UTC
Integrated into 'main-golden', will be available in build *201305102300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c28a838f5c2a
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: #229551 - Patch for: "Specify git repository location" dialog: Usability issues
Comment 5 markiewb 2013-07-23 22:07:17 UTC
Verified in 201307222300